summaryrefslogtreecommitdiff
path: root/src/mainboard/roda
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2022-12-02 19:16:21 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2022-12-07 11:33:38 +0000
commit521e0460e4292ff0bdaad4ca3861603d13ccfe1d (patch)
treed0f50fdf75599471abca42603c6a1f21f348cfb6 /src/mainboard/roda
parent2c3ebd8b9d56c01d8e4adadf6f4e4d5b56cdb4e1 (diff)
sb,soc/intel,mb: Drop leftover comments and TODOs in ASL
Change-Id: I74f943e9b616458a16aa13c29706cf1551fcbbb2 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70366 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/mainboard/roda')
-rw-r--r--src/mainboard/roda/rk886ex/acpi/platform.asl29
-rw-r--r--src/mainboard/roda/rk9/acpi/platform.asl33
2 files changed, 0 insertions, 62 deletions
diff --git a/src/mainboard/roda/rk886ex/acpi/platform.asl b/src/mainboard/roda/rk886ex/acpi/platform.asl
index 42277c4c76..646a120acc 100644
--- a/src/mainboard/roda/rk886ex/acpi/platform.asl
+++ b/src/mainboard/roda/rk886ex/acpi/platform.asl
@@ -6,31 +6,12 @@
Method(_PTS,1)
{
- // Call a trap so SMI can prepare for Sleep as well.
- // TRAP(0x55)
}
/* The _WAK method is called on system wakeup */
Method(_WAK,1)
{
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (Arg0 == 3) {
- // ..
- }
-
- // Are we going to S4?
- If (Arg0 == 4) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
Return(Package(){0,0})
}
@@ -43,16 +24,6 @@ Scope(\_SB)
*/
Method(_INI, 0)
{
- /* The DTS data in NVS is probably not up to date.
- * Update temperature values and make sure AP thermal
- * interrupts can happen
- */
-
- // TRAP(71) // TODO
-
\GOS()
-
- /* SMM power state and C4-on-C3 settings need to be updated */
- // TRAP(43) // TODO
}
}
diff --git a/src/mainboard/roda/rk9/acpi/platform.asl b/src/mainboard/roda/rk9/acpi/platform.asl
index 00ac2735ed..982de31bf1 100644
--- a/src/mainboard/roda/rk9/acpi/platform.asl
+++ b/src/mainboard/roda/rk9/acpi/platform.asl
@@ -6,34 +6,11 @@
Method(_PTS,1)
{
- // Call a trap so SMI can prepare for Sleep as well.
- // TRAP(0x55)
}
/* The _WAK method is called on system wakeup */
-
Method(_WAK,1)
{
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (Arg0 == 3) {
- // ..
- }
-
- // Are we going to S4?
- If (Arg0 == 4) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
- // TODO: Return Arg0 as second value if S-Arg0 was entered
- // before.
-
Return(Package(){0,0})
}
@@ -46,16 +23,6 @@ Scope(\_SB)
*/
Method(_INI, 0)
{
- /* The DTS data in NVS is probably not up to date.
- * Update temperature values and make sure AP thermal
- * interrupts can happen
- */
-
- // TRAP(71) // TODO
-
\GOS()
-
- /* SMM power state and C4-on-C3 settings need to be updated */
- // TRAP(43) // TODO
}
}