diff options
author | Furquan Shaikh <furquan@google.com> | 2021-03-03 09:45:50 -0800 |
---|---|---|
committer | Furquan Shaikh <furquan@google.com> | 2021-03-05 03:53:16 +0000 |
commit | 338d668b6f0cd3ec893a23a0ef084b419dbf7040 (patch) | |
tree | dedbe5aff5615b86802cf14631e6bf7ff355ff82 /src/mainboard/razer | |
parent | 4a88b03a6c8297fd0a654de1f4aa46d46976e0f3 (diff) |
soc/intel/tigerlake: Fix NULL being passed for response buffer
`pmc_send_ipc_cmd()` expects the caller to pass in a pointer to a valid
request and response buffer. However, early_tcss driver was passing in
a NULL pointer for response buffer which would result in invalid
access by `pmc_send_ipc_cmd()`.
Currently, the response buffer is not used in `update_tcss_mux()`. So,
this change drops the passing of `rbuf` parameter to `send_pmc*`
helpers and instead uses a local `rsp` variable in the respective
functions. All the PMC functions used in early_tcss driver return some
kind of response. These should be checked to return appropriate
response code back to the caller. However, this needs to be done as a
separate change.
Change-Id: I215af85feed60b6beee17f28e3d65daa9ad4ae69
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51232
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/mainboard/razer')
0 files changed, 0 insertions, 0 deletions