diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-06-23 14:39:32 +0200 |
|---|---|---|
| committer | Angel Pons <th3fanbus@gmail.com> | 2022-08-14 10:53:47 +0000 |
| commit | 333751b22e046793d84d72d1053b9c6aa2854d77 (patch) | |
| tree | 5750680fb5ba2834b7cff29ae813f145972b7b9b /src/mainboard/purism | |
| parent | eb80d8da8862aa49b0b6b67e0166fa831f8f1343 (diff) | |
broadwell: Compute channel disable masks at runtime
Introduce the `SPD_MEMORY_DOWN` macro to indicate that a slot is used
with memory-down. This enables computing the channel disable masks as
the bits for slots where the SPD address is zero. To preserve current
behavior, zero the SPD addresses for memory-down slots afterwards.
Change-Id: I75b7be7c72062d1a26cfc7b09b79de62de0a9cea
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55807
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/purism')
| -rw-r--r-- | src/mainboard/purism/librem_bdw/variants/librem13v1/pei_data.c | 1 | ||||
| -rw-r--r-- | src/mainboard/purism/librem_bdw/variants/librem15v2/pei_data.c | 3 |
2 files changed, 0 insertions, 4 deletions
diff --git a/src/mainboard/purism/librem_bdw/variants/librem13v1/pei_data.c b/src/mainboard/purism/librem_bdw/variants/librem13v1/pei_data.c index 64cac287c1..0025617146 100644 --- a/src/mainboard/purism/librem_bdw/variants/librem13v1/pei_data.c +++ b/src/mainboard/purism/librem_bdw/variants/librem13v1/pei_data.c @@ -6,7 +6,6 @@ void mainboard_fill_spd_data(struct pei_data *pei_data) { /* One DIMM slot */ - pei_data->dimm_channel1_disabled = 3; pei_data->spd_addresses[0] = 0xa0; } diff --git a/src/mainboard/purism/librem_bdw/variants/librem15v2/pei_data.c b/src/mainboard/purism/librem_bdw/variants/librem15v2/pei_data.c index 275cbadeee..1cb7e756e7 100644 --- a/src/mainboard/purism/librem_bdw/variants/librem15v2/pei_data.c +++ b/src/mainboard/purism/librem_bdw/variants/librem15v2/pei_data.c @@ -8,9 +8,6 @@ void mainboard_fill_spd_data(struct pei_data *pei_data) pei_data->dq_pins_interleaved = 1; /* One DIMM slot */ - pei_data->dimm_channel0_disabled = 2; - pei_data->dimm_channel1_disabled = 2; - pei_data->spd_addresses[0] = 0xa0; pei_data->spd_addresses[2] = 0xa4; } |