diff options
| author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2024-01-25 15:15:00 +0100 |
|---|---|---|
| committer | Lean Sheng Tan <sheng.tan@9elements.com> | 2024-02-06 08:21:05 +0000 |
| commit | 7a593ab0bb6ad33db39d49745a07b382996cc4e9 (patch) | |
| tree | 849a01dcb8df397fa9f1cdffcb476472f52210ed /src/mainboard/ocp | |
| parent | fe33b2dd86e41be96a1943e381cadf2b3a722356 (diff) | |
soc/intel/xeon_sp/smihandler: Lock SMM_FEATURE_CONTROL on all sockets
Remove hardcoded B:D:F numbers for the first socket and pass the PCI
addresses to be locked within SMM by using the smm_pci_resource_store.
This allows to lock down SMM on all sockets without knowing the actual
bus topology or PCI segment group at compile time where the UBOX devices
reside on.
Tested: SMM is locked on all 4 sockets instead of just one.
Change-Id: Ica694911384005681662d3d7bed354a60bf08911
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80247
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/ocp')
| -rw-r--r-- | src/mainboard/ocp/deltalake/ramstage.c | 7 | ||||
| -rw-r--r-- | src/mainboard/ocp/tiogapass/ramstage.c | 7 |
2 files changed, 14 insertions, 0 deletions
diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index c24d004ed0..f846055fc2 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -4,6 +4,7 @@ #include <commonlib/bsd/helpers.h> #include <console/console.h> #include <cpu/cpu.h> +#include <cpu/x86/smm.h> #include <cpxsp_dl_gpio.h> #include <device/device.h> #include <device/pci_def.h> @@ -16,6 +17,7 @@ #include <security/intel/txt/txt.h> #include <smbios.h> #include <soc/ramstage.h> +#include <soc/smmrelocate.h> #include <soc/soc_util.h> #include <soc/util.h> #include <stdio.h> @@ -335,6 +337,11 @@ struct chip_operations mainboard_ops = { .final = mainboard_final, }; +void smm_mainboard_pci_resource_store_init(struct smm_pci_resource_info *slots, size_t size) +{ + soc_ubox_store_resources(slots, size); +} + bool skip_intel_txt_lockdown(void) { static bool fetched_vpd = 0; diff --git a/src/mainboard/ocp/tiogapass/ramstage.c b/src/mainboard/ocp/tiogapass/ramstage.c index c69322b77a..a07edb80e8 100644 --- a/src/mainboard/ocp/tiogapass/ramstage.c +++ b/src/mainboard/ocp/tiogapass/ramstage.c @@ -1,8 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#include <cpu/x86/smm.h> #include <drivers/ipmi/ipmi_ops.h> #include <drivers/ocp/dmi/ocp_dmi.h> #include <soc/ramstage.h> +#include <soc/smmrelocate.h> extern struct fru_info_str fru_strings; @@ -176,6 +178,11 @@ static void mainboard_final(void *chip_info) { } +void smm_mainboard_pci_resource_store_init(struct smm_pci_resource_info *slots, size_t size) +{ + soc_ubox_store_resources(slots, size); +} + struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, .final = mainboard_final, |