diff options
author | Julius Werner <jwerner@chromium.org> | 2019-03-27 14:47:09 -0700 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2019-04-10 10:44:31 +0000 |
commit | 0de2fa0a622d72d63d64a3d73b4b7ead24380314 (patch) | |
tree | b8d820e3021c60baf65afdd45eb126518cfee476 /src/mainboard/ocp/monolake/board.fmd | |
parent | 18c1b6b240b675c877b8bd731dfd58f5723d0c57 (diff) |
libpayload: Deduplicate strtol and strtoull
Our strtol() and strtoull() function contain almost exactly the same
code. This is a) bad in general and b) may cause the code to get out of
sync, such as it recently happened with CB:32029.
This patch changes strtol() to be based on strtoull() so that the main
parsing code exists only once, and also adds a strtoll() to round off
the library. Also fix the bounds imposed by strtoul() to be based on the
actual length of a 'long', not hardcoded to 32-bits (which is not
equivalent on all architectures).
Change-Id: I919c65a773cecdb11739c3f22dd0d182ed50c07f
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32086
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/mainboard/ocp/monolake/board.fmd')
0 files changed, 0 insertions, 0 deletions