nb/intel/sandybridge: Use an enum for `gpu_panel_port_select`

All boards currently have backlight on either LVDS or eDP.

Change-Id: I878bc7f1ff75a2b82b9556e855aff1d4d03e0268
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45035
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>

14 files changed, 14 insertions, 14 deletions

diff --git a/src/mainboard/lenovo/l520/devicetree.cb b/src/mainboard/lenovo/l520/devicetree.cb
index 93390c9112..bab1d54f39 100644
--- a/src/mainboard/lenovo/l520/devicetree.cb
+++ b/src/mainboard/lenovo/l520/devicetree.cb
@@ -4,7 +4,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_b_hotplug" = "0"
 	register "gpu_dp_c_hotplug" = "0"
 	register "gpu_dp_d_hotplug" = "0"
-	register "gpu_panel_port_select" = "0"
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_backlight_off_delay" = "0"
 	register "gpu_panel_power_backlight_on_delay" = "0"
 	register "gpu_panel_power_cycle_delay" = "0"
diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb
index 6f4e6082d5..f3b8c27784 100644
--- a/src/mainboard/lenovo/s230u/devicetree.cb
+++ b/src/mainboard/lenovo/s230u/devicetree.cb
@@ -4,7 +4,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_b_hotplug" = "4"
 	register "gpu_dp_c_hotplug" = "4"
 	register "gpu_dp_d_hotplug" = "4"
-	register "gpu_panel_port_select" = "0"
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_backlight_off_delay" = "2000"
 	register "gpu_panel_power_backlight_on_delay" = "2000"
 	register "gpu_panel_power_cycle_delay" = "5"
diff --git a/src/mainboard/lenovo/t420/devicetree.cb b/src/mainboard/lenovo/t420/devicetree.cb
index 5ac9cf5a96..ef40fc4dde 100644
--- a/src/mainboard/lenovo/t420/devicetree.cb
+++ b/src/mainboard/lenovo/t420/devicetree.cb
@@ -6,7 +6,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "0x06"
 
 	# Enable Panel as LVDS and configure power delays
-	register "gpu_panel_port_select" = "0"			# LVDS
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_cycle_delay" = "1"
 	register "gpu_panel_power_up_delay" = "300"		# T1+T2: 30ms
 	register "gpu_panel_power_down_delay" = "300"		# T5+T6: 30ms
diff --git a/src/mainboard/lenovo/t420s/devicetree.cb b/src/mainboard/lenovo/t420s/devicetree.cb
index b3399c32a3..71068d0005 100644
--- a/src/mainboard/lenovo/t420s/devicetree.cb
+++ b/src/mainboard/lenovo/t420s/devicetree.cb
@@ -6,7 +6,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "0x06"
 
 	# Enable Panel as LVDS and configure power delays
-	register "gpu_panel_port_select" = "0"			# LVDS
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_cycle_delay" = "1"
 	register "gpu_panel_power_up_delay" = "300"		# T1+T2: 30ms
 	register "gpu_panel_power_down_delay" = "300"		# T5+T6: 30ms
diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb
index 95eaa99337..f3524cd999 100644
--- a/src/mainboard/lenovo/t430/devicetree.cb
+++ b/src/mainboard/lenovo/t430/devicetree.cb
@@ -5,7 +5,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "0x06"
 
 	# Enable Panel as LVDS and configure power delays
-	register "gpu_panel_port_select" = "0"			# LVDS
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_cycle_delay" = "6"		# T7: 500ms
 	register "gpu_panel_power_up_delay" = "100"		# T1+T2: 10ms
 	register "gpu_panel_power_down_delay" = "100"		# T5+T6: 10ms
diff --git a/src/mainboard/lenovo/t430s/devicetree.cb b/src/mainboard/lenovo/t430s/devicetree.cb
index 40c706eb0c..4bdb923b12 100644
--- a/src/mainboard/lenovo/t430s/devicetree.cb
+++ b/src/mainboard/lenovo/t430s/devicetree.cb
@@ -5,7 +5,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "0x06"
 
 	# Enable Panel as LVDS and configure power delays
-	register "gpu_panel_port_select" = "0"			# LVDS
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_cycle_delay" = "6"		# T7: 500ms
 	register "gpu_panel_power_up_delay" = "100"		# T1+T2: 10ms
 	register "gpu_panel_power_down_delay" = "100"		# T5+T6: 10ms
diff --git a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
index ae95e6c8d6..41bef2f70e 100644
--- a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
+++ b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
@@ -5,7 +5,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "4"
 
 	# Enable Panel as eDP and configure power delays
-	register "gpu_panel_port_select" = "1"			# eDP
+	register "gpu_panel_port_select" = "PANEL_PORT_DP_A"
 	register "gpu_panel_power_up_delay" = "2000"		# 200ms
 	register "gpu_panel_power_down_delay" = "500"		# 50ms
 	register "gpu_panel_power_backlight_on_delay" = "1"	# 0.1ms
diff --git a/src/mainboard/lenovo/t520/devicetree.cb b/src/mainboard/lenovo/t520/devicetree.cb
index 5128d06e4b..cc1e7f2999 100644
--- a/src/mainboard/lenovo/t520/devicetree.cb
+++ b/src/mainboard/lenovo/t520/devicetree.cb
@@ -6,7 +6,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "0x06"
 
 	# Enable Panel as LVDS and configure power delays
-	register "gpu_panel_port_select" = "0"			# LVDS
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_cycle_delay" = "5"
 	register "gpu_panel_power_up_delay" = "300"		# T1+T2: 30ms
 	register "gpu_panel_power_down_delay" = "300"		# T5+T6: 30ms
diff --git a/src/mainboard/lenovo/t530/devicetree.cb b/src/mainboard/lenovo/t530/devicetree.cb
index 1b16ca3b2c..e4655b2f29 100644
--- a/src/mainboard/lenovo/t530/devicetree.cb
+++ b/src/mainboard/lenovo/t530/devicetree.cb
@@ -6,7 +6,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "0x06"
 
 	# Enable Panel as LVDS and configure power delays
-	register "gpu_panel_port_select" = "0"			# LVDS
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_cycle_delay" = "6"		# T7: 500ms
 	register "gpu_panel_power_up_delay" = "100"		# T1+T2: 10ms
 	register "gpu_panel_power_down_delay" = "100"		# T5+T6: 10ms
diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb
index c84d7ea87d..ddbfd98491 100644
--- a/src/mainboard/lenovo/x131e/devicetree.cb
+++ b/src/mainboard/lenovo/x131e/devicetree.cb
@@ -5,7 +5,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "0x04"
 
 	# Enable Panel as LVDS and configure power delays
-	register "gpu_panel_port_select" = "0"
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_cycle_delay" = "4"
 	register "gpu_panel_power_up_delay" = "100"
 	register "gpu_panel_power_down_delay" = "100"
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb b/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
index b3c11ea450..34eaa75c13 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
+++ b/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
@@ -4,7 +4,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_b_hotplug" = "4"
 	register "gpu_dp_c_hotplug" = "4"
 	register "gpu_dp_d_hotplug" = "4"
-	register "gpu_panel_port_select" = "0"
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_backlight_off_delay" = "2000"
 	register "gpu_panel_power_backlight_on_delay" = "3000"
 	register "gpu_panel_power_cycle_delay" = "6"
diff --git a/src/mainboard/lenovo/x220/devicetree.cb b/src/mainboard/lenovo/x220/devicetree.cb
index bfb9da355d..609036d61c 100644
--- a/src/mainboard/lenovo/x220/devicetree.cb
+++ b/src/mainboard/lenovo/x220/devicetree.cb
@@ -6,7 +6,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "0x06"
 
 	# Enable Panel as LVDS and configure power delays
-	register "gpu_panel_port_select" = "0"			# LVDS
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_cycle_delay" = "5"
 	register "gpu_panel_power_up_delay" = "300"		# T1+T2: 30ms
 	register "gpu_panel_power_down_delay" = "300"		# T5+T6: 30ms
diff --git a/src/mainboard/lenovo/x230/devicetree.cb b/src/mainboard/lenovo/x230/devicetree.cb
index 085b4e137b..27d42b68be 100644
--- a/src/mainboard/lenovo/x230/devicetree.cb
+++ b/src/mainboard/lenovo/x230/devicetree.cb
@@ -6,7 +6,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "0x06"
 
 	# Enable Panel as LVDS and configure power delays
-	register "gpu_panel_port_select" = "0"			# LVDS
+	register "gpu_panel_port_select" = "PANEL_PORT_LVDS"
 	register "gpu_panel_power_cycle_delay" = "6"		# T7: 500ms
 	register "gpu_panel_power_up_delay" = "100"		# T1+T2: 10ms
 	register "gpu_panel_power_down_delay" = "100"		# T5+T6: 10ms
diff --git a/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb b/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb
index 9e9d956935..b2d0cf20a5 100644
--- a/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb
+++ b/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb
@@ -5,7 +5,7 @@ chip northbridge/intel/sandybridge
 	register "gpu_dp_d_hotplug" = "4"
 
 	# Enable Panel as eDP and configure power delays
-	register "gpu_panel_port_select" = "1"			# eDP
+	register "gpu_panel_port_select" = "PANEL_PORT_DP_A"
 	register "gpu_panel_power_backlight_off_delay" = "1"	# 0.1ms
 	register "gpu_panel_power_backlight_on_delay" = "1"	# 0.1ms
 	register "gpu_panel_power_down_delay" = "500"		# 50ms