drivers/generic/ioapic: Drop poor implementation

This disables MP table generation for the affected boards
since interrupt routing entries would now be completely missing.

The mechanism itself is flawed and redundant. The mapping
of integrated PCI devices' INTx pins to IOAPIC pins is
dependent of configuration registers and needs not appear
in the devicetree.cb files at all.

The write_smp_table implementation would skip writing
any entry delivering to destination IOAPIC ID 0. This
does not follow MP table specification.

There were duplicate calls to register_new_ioapic_gsi0(),
with another present under southbridge LPC device.

Change-Id: I383d55ba2bc0800423617215e0bfdfad5136e9ac
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69488
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

2 files changed, 0 insertions, 21 deletions

diff --git a/src/mainboard/lenovo/x200/Kconfig b/src/mainboard/lenovo/x200/Kconfig
index 812ceeec7c..86693009a2 100644
--- a/src/mainboard/lenovo/x200/Kconfig
+++ b/src/mainboard/lenovo/x200/Kconfig
@@ -11,8 +11,6 @@ config BOARD_SPECIFIC_OPTIONS
 	select H8_HAS_BAT_THRESHOLDS_IMPL
 	select NO_UART_ON_SUPERIO
 	select BOARD_ROMSIZE_KB_8192
-	select DRIVERS_GENERIC_IOAPIC
-	select HAVE_MP_TABLE
 	select HAVE_ACPI_TABLES
 	select EC_ACPI
 	select HAVE_OPTION_TABLE
diff --git a/src/mainboard/lenovo/x200/devicetree.cb b/src/mainboard/lenovo/x200/devicetree.cb
index dd631a7034..059dc005cb 100644
--- a/src/mainboard/lenovo/x200/devicetree.cb
+++ b/src/mainboard/lenovo/x200/devicetree.cb
@@ -33,7 +33,6 @@ chip northbridge/intel/gm45
 		end # host bridge
 		device pci 02.0 on # VGA
 			subsystemid 0x17aa 0x20e4
-			ioapic_irq 2 INTA 0x10
 		end
 		device pci 02.1 on
 			subsystemid 0x17aa 0x20e4
@@ -78,27 +77,21 @@ chip northbridge/intel/gm45
 			device pci 19.0 on end # LAN
 			device pci 1a.0 on # UHCI
 				subsystemid 0x17aa 0x20f0
-				ioapic_irq 2 INTA 0x10
 			end
 			device pci 1a.1 on # UHCI
 				subsystemid 0x17aa 0x20f0
-				ioapic_irq 2 INTB 0x11
 			end
 			device pci 1a.2 on # UHCI
 				subsystemid 0x17aa 0x20f0
-				ioapic_irq 2 INTC 0x12
 			end
 			device pci 1a.7 on # EHCI
 				subsystemid 0x17aa 0x20f1
-				ioapic_irq 2 INTC 0x12
 			end
 			device pci 1b.0 on # HD Audio
 				subsystemid 0x17aa 0x20f2
-				ioapic_irq 2 INTA 0x10
 			end
 			device pci 1c.0 on # PCIe Port #1
 				subsystemid 0x17aa 0x20f3 # WWAN
-				ioapic_irq 2 INTA 0x10
 			end
 			device pci 1c.1 on
 				subsystemid 0x17aa 0x20f3 # WLAN
@@ -111,19 +104,15 @@ chip northbridge/intel/gm45
 			device pci 1c.5 off end # PCIe Port #6
 			device pci 1d.0 on # UHCI
 				subsystemid 0x17aa 0x20f0
-				ioapic_irq 2 INTA 0x10
 			end
 			device pci 1d.1 on # UHCI
 				subsystemid 0x17aa 0x20f0
-				ioapic_irq 2 INTB 0x11
 			end
 			device pci 1d.2 on # UHCI
 				subsystemid 0x17aa 0x20f0
-				ioapic_irq 2 INTC 0x12
 			end
 			device pci 1d.7 on # EHCI
 				subsystemid 0x17aa 0x20f1
-				ioapic_irq 2 INTA 0x10
 			end
 			device pci 1e.0 on # PCI
 				subsystemid 0x17aa 0x20f4
@@ -131,12 +120,6 @@ chip northbridge/intel/gm45
 			device pci 1f.0 on # LPC bridge
 				subsystemid 0x17aa 0x20f5
 
-				chip drivers/generic/ioapic
-					register "have_isa_interrupts" = "1"
-					register "base" = "(void *)0xfec00000"
-					device ioapic 2 on end
-				end
-
 				chip ec/lenovo/pmh7
 					device pnp ff.1 on end # dummy
 					register "backlight_enable" = "0x01"
@@ -180,11 +163,9 @@ chip northbridge/intel/gm45
 			end
 			device pci 1f.2 on # SATA/IDE 1
 				subsystemid 0x17aa 0x20f8
-				ioapic_irq 2 INTB 0x11
 			end
 			device pci 1f.3 on # SMBus
 				subsystemid 0x17aa 0x20f9
-				ioapic_irq 2 INTC 0x12
 				# eeprom, 8 virtual devices, same chip
 				chip drivers/i2c/at24rf08c
 					device i2c 54 on end