summaryrefslogtreecommitdiff
path: root/src/mainboard/kontron
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2023-10-23 08:30:02 +0200
committerFelix Held <felix-coreboot@felixheld.de>2023-10-25 14:22:18 +0000
commiteb1a2bd1325d1f783a8062a4a762843dc75d4869 (patch)
treee135b9b97a3dcaea6aaa3d2bf6320a448451aff4 /src/mainboard/kontron
parentc4b846f22ab84a9c43b10cca53c78a9c0c8016d5 (diff)
mb/kontron/bsl6/devicetree: Use comma separated list for arrays
In order to improve the readability of the settings, use a comma separated list to assign values to their indexes instead of repeating the option name for each index. Don't convert the settings for PCIe root ports as they should stay in the devicetree at their related root ports. While on it, remove superfluous comments related to modified settings. Change-Id: I67f4fdcfb59da6c594c89d7ad3ee7f2ddbbea69b Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78592 Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/kontron')
-rw-r--r--src/mainboard/kontron/bsl6/devicetree.cb23
1 files changed, 13 insertions, 10 deletions
diff --git a/src/mainboard/kontron/bsl6/devicetree.cb b/src/mainboard/kontron/bsl6/devicetree.cb
index 46bfd95af5..1659834604 100644
--- a/src/mainboard/kontron/bsl6/devicetree.cb
+++ b/src/mainboard/kontron/bsl6/devicetree.cb
@@ -70,20 +70,23 @@ chip soc/intel/skylake
device pci 02.0 on end # Integrated Graphics Device
device pci 08.0 on end # Gaussian Mixture Model
device pci 14.0 on # USB xHCI
- register "usb2_ports[0]" = "USB2_PORT_LONG(OC0)"
- register "usb2_ports[1]" = "USB2_PORT_LONG(OC0)"
- register "usb2_ports[2]" = "USB2_PORT_LONG(OC1)"
- register "usb2_ports[3]" = "USB2_PORT_LONG(OC1)"
- register "usb2_ports[4]" = "USB2_PORT_LONG(OC2)" # Debug
+ register "usb2_ports" = "{
+ [0] = USB2_PORT_LONG(OC0),
+ [1] = USB2_PORT_LONG(OC0),
+ [2] = USB2_PORT_LONG(OC1),
+ [3] = USB2_PORT_LONG(OC1),
+ [4] = USB2_PORT_LONG(OC2), /* Debug */
+ }"
end
device pci 14.2 on end # Thermal Subsystem
device pci 16.0 on end # Management Engine Interface 1
device pci 17.0 on # SATA
- register "SataSalpSupport" = "1"
- register "SataPortsEnable[0]" = "1"
- register "SataPortsEnable[1]" = "1"
- register "SataPortsEnable[2]" = "1"
- # SataPortsDevSlp not supported
+ register "SataSalpSupport" = "1"
+ register "SataPortsEnable" = "{
+ [0] = 1,
+ [1] = 1,
+ [2] = 1,
+ }"
end
device pci 1d.0 on # PCI Express Port 9 (COMe 0)
register "PcieRpEnable[8]" = "1"