diff options
| author | Martin Roth <martinroth@google.com> | 2015-12-08 14:00:07 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2015-12-10 16:32:21 +0100 |
| commit | f77516cb6dcc4671938475926d2ee55952cd2eec (patch) | |
| tree | 67dd2c2237ed9c55da4166d332817f90e28a08e4 /src/mainboard/jetway | |
| parent | 91d9cbc2fbc62ede85e4eae07c52c43ffe7a4eb3 (diff) | |
ACPI: Work around IASL warning reading/writing same register
The newer versions of IASL are unhappy when an operator
has the same object as both source and destination.
The warning can be completely disabled with a command
line argument, but in general, I'd really rather not
just disable warnings.
The bits in this register are write 1 to clear, so reading and
writing the same register is what we want to do. Instead, store
it in a temporary register then write it in a second operation.
Fixes warning:
dsdt.aml 1396: Store(PWST, PWST)
Warning 3023 - ^ Duplicate value in list
(Source is the same as Target)
Change-Id: I52d73d4431db237be83016d67cd397f31b53d9c6
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12691
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard/jetway')
| -rw-r--r-- | src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl | 3 | ||||
| -rw-r--r-- | src/mainboard/jetway/pa78vm5/dsdt.asl | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl index e043ee211b..b3fd07ef00 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl @@ -104,7 +104,8 @@ Method(\_WAK, 1) { } /* Arbitrarily clear PciExpWakeStatus */ - Store(PWST, PWST) + Store(PWST, Local1) + Store(Local1, PWST) /* if(DeRefOf(Index(WKST,0))) { * Store(0, Index(WKST,1)) diff --git a/src/mainboard/jetway/pa78vm5/dsdt.asl b/src/mainboard/jetway/pa78vm5/dsdt.asl index eae9bbeab2..507ef3ba40 100644 --- a/src/mainboard/jetway/pa78vm5/dsdt.asl +++ b/src/mainboard/jetway/pa78vm5/dsdt.asl @@ -937,7 +937,8 @@ DefinitionBlock ( } /* Arbitrarily clear PciExpWakeStatus */ - Store(PWST, PWST) + Store(PWST, Local1) + Store(Local1, PWST) /* if(DeRefOf(Index(WKST,0))) { * Store(0, Index(WKST,1)) |