summaryrefslogtreecommitdiff
path: root/src/mainboard/intel/tglrvp/bootblock.c
diff options
context:
space:
mode:
authorMichael Niewöhner <foss@mniewoehner.de>2020-12-21 03:46:58 +0100
committerMichael Niewöhner <foss@mniewoehner.de>2021-01-21 18:41:28 +0000
commit1d05a3bf56a63fc286719648f0c2c58a23dff80a (patch)
treedb69e1ea70ccb623595931c58d457b228006f163 /src/mainboard/intel/tglrvp/bootblock.c
parent4940255a407ac6ac0b9153b0db847189d6308959 (diff)
mb/intel/tglrvp: do UART pad config at board-level
UART pad configuration should not be done in common code, because that may cause short circuits, when the user sets a wrong UART index. Thus, add the corresponding pads to the early UART gpio table for the board as a first step. Common UART pad config code then gets dropped in CB:48829. Also switch to `bootblock_mainboard_early_init` to configure the pads in early bootblock before console initialization, to make the console work as early as possible. The board does not do any other gpio configuration in bootblock, so this should not influence behaviour in a negative way (e.g. breaking overrides). Change-Id: I130fd26944169430a84c3609432b1b5283581c99 Signed-off-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49432 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/intel/tglrvp/bootblock.c')
-rw-r--r--src/mainboard/intel/tglrvp/bootblock.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/intel/tglrvp/bootblock.c b/src/mainboard/intel/tglrvp/bootblock.c
index a8f7e41433..d7f3255974 100644
--- a/src/mainboard/intel/tglrvp/bootblock.c
+++ b/src/mainboard/intel/tglrvp/bootblock.c
@@ -5,7 +5,7 @@
#include <bootblock_common.h>
#include <soc/gpio.h>
-void bootblock_mainboard_init(void)
+void bootblock_mainboard_early_init(void)
{
const struct pad_config *pads;
size_t num;