summaryrefslogtreecommitdiff
path: root/src/mainboard/hp
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2022-05-16 15:29:53 +0200
committerMartin L Roth <gaumless@tutanota.com>2022-05-28 04:19:20 +0000
commitb80de180c2ebd7bde5ce4da43d5e0f0c260c25e7 (patch)
treebf61ae47c74d627362d88675822bcc1db8b37b9e /src/mainboard/hp
parent704ccafb392212cffc3810197da5cb2b619f1ba6 (diff)
vendorcode/amd/agesa/fam16kb: Fix improper use of .data
AGESA has a lot of code in the .data section which is for initialized data, that in fact should be .rodata. This adds the 'CONST' keyword everywhere it is needed. TEST: See in the .elf file (e.g. using readelf) that there is nothing in .data section. Change-Id: Ie8817434ee0bc6c195eabe090f195512c0043ae5 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/64400 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard/hp')
-rw-r--r--src/mainboard/hp/abm/buildOpts.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/hp/abm/buildOpts.c b/src/mainboard/hp/abm/buildOpts.c
index 2d1128644b..fd4323acba 100644
--- a/src/mainboard/hp/abm/buildOpts.c
+++ b/src/mainboard/hp/abm/buildOpts.c
@@ -43,7 +43,7 @@
#include "cpuLateInit.h"
#include "GnbInterface.h"
-GPIO_CONTROL hp_abm_gpio[] = {
+CONST GPIO_CONTROL hp_abm_gpio[] = {
{ 45, Function2, GpioOutEnB | Sticky }, // Signal input APU_SD_LED
{ 49, Function2, PullUpB | PullDown | Sticky }, // Signal output APU_ABM_LED_UID
{ 50, Function2, PullUpB | PullDown | Sticky }, // Signal output APU_ABM_LED_HEALTH