aboutsummaryrefslogtreecommitdiff
path: root/src/mainboard/google
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-03-08 10:35:49 +0100
committerFelix Singer <felixsinger@posteo.net>2021-10-15 09:08:35 +0000
commit05ae8f2ff31ba1d02aba15c99025df91588712e1 (patch)
tree9828f45dcfca1ed85f6e07c82d68d279dc8f2da1 /src/mainboard/google
parentdcc0cc27f4a728e96dd85b88f7321edfcfd7add9 (diff)
mainboard: Drop invalid `VGA_BIOS_FILE` defaults
If the VGA BIOS file path for `VGA_BIOS_FILE` in a mainboard's Kconfig does not exist in the coreboot tree (including submodules), drop it. These files should be stored in the `site-local` subdirectory and the paths specified for each board in `site-local/Kconfig`. For example: config VGA_BIOS_FILE default "site-local/x200_vbios.bin" if BOARD_LENOVO_X200 Note that this is just an example. There are better ways to structure one's `site-local` subfolder. Using the `CONFIG_MAINBOARD_DIR` option would be one of them, though variants may still need special handling. Also, update autoport to not generate `VGA_BIOS_FILE` defaults. Change-Id: I1b5dfba035a42d7943f270f95fb7d32b285584d2 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51340 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-by: Felix Singer <felixsinger@posteo.net>
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/auron/Kconfig4
-rw-r--r--src/mainboard/google/beltino/Kconfig4
-rw-r--r--src/mainboard/google/butterfly/Kconfig4
-rw-r--r--src/mainboard/google/jecht/Kconfig4
-rw-r--r--src/mainboard/google/link/Kconfig4
-rw-r--r--src/mainboard/google/parrot/Kconfig4
-rw-r--r--src/mainboard/google/slippy/Kconfig4
-rw-r--r--src/mainboard/google/stout/Kconfig4
8 files changed, 0 insertions, 32 deletions
diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig
index 0d37a10826..61447fdacb 100644
--- a/src/mainboard/google/auron/Kconfig
+++ b/src/mainboard/google/auron/Kconfig
@@ -51,10 +51,6 @@ config EC_GOOGLE_CHROMEEC_BOARDNAME
default "samus" if BOARD_GOOGLE_SAMUS
default ""
-config VGA_BIOS_FILE
- string
- default "pci8086,0406.rom"
-
config MAINBOARD_SMBIOS_MANUFACTURER
string
default "GOOGLE"
diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig
index 8ecba7ad03..00b33ad4ab 100644
--- a/src/mainboard/google/beltino/Kconfig
+++ b/src/mainboard/google/beltino/Kconfig
@@ -40,10 +40,6 @@ config MAINBOARD_FAMILY
string
default "Google_Beltino"
-config VGA_BIOS_FILE
- string
- default "pci8086,0406.rom"
-
# Override the default variant behavior, since the data.vbt is the same
# for all variants except monroe
config INTEL_GMA_VBT_FILE
diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig
index 55d731b289..4eb151efc1 100644
--- a/src/mainboard/google/butterfly/Kconfig
+++ b/src/mainboard/google/butterfly/Kconfig
@@ -31,10 +31,6 @@ config MAINBOARD_DIR
config MAINBOARD_PART_NUMBER
default "Butterfly"
-config VGA_BIOS_FILE
- string
- default "pci8086,0106.rom"
-
config MAINBOARD_VENDOR
string
default "Hewlett-Packard"
diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig
index 42be86ab28..2f54be9b3b 100644
--- a/src/mainboard/google/jecht/Kconfig
+++ b/src/mainboard/google/jecht/Kconfig
@@ -33,10 +33,6 @@ config MAINBOARD_PART_NUMBER
default "Rikku" if BOARD_GOOGLE_RIKKU
default "Tidus" if BOARD_GOOGLE_TIDUS
-config VGA_BIOS_FILE
- string
- default "pci8086,0406.rom"
-
# Override the default variant behavior, since the data.vbt is the same
# for all variants except tidus
config INTEL_GMA_VBT_FILE
diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig
index 6926ca18c8..ee68e46df9 100644
--- a/src/mainboard/google/link/Kconfig
+++ b/src/mainboard/google/link/Kconfig
@@ -31,10 +31,6 @@ config MAINBOARD_DIR
config MAINBOARD_PART_NUMBER
default "Link"
-config VGA_BIOS_FILE
- string
- default "pci8086,0166.rom"
-
config MAINBOARD_SMBIOS_MANUFACTURER
string
default "GOOGLE"
diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig
index e596951bcd..5fffcc14de 100644
--- a/src/mainboard/google/parrot/Kconfig
+++ b/src/mainboard/google/parrot/Kconfig
@@ -32,10 +32,6 @@ config MAINBOARD_DIR
config MAINBOARD_PART_NUMBER
default "Parrot"
-config VGA_BIOS_FILE
- string
- default "pci8086,0106.rom"
-
config MAINBOARD_SMBIOS_MANUFACTURER
string
default "GOOGLE"
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig
index 7bb717be29..e8963f793a 100644
--- a/src/mainboard/google/slippy/Kconfig
+++ b/src/mainboard/google/slippy/Kconfig
@@ -48,10 +48,6 @@ config MAINBOARD_FAMILY
config OVERRIDE_DEVICETREE
default "variants/\$(CONFIG_VARIANT_DIR)/overridetree.cb"
-config VGA_BIOS_FILE
- string
- default "pci8086,0406.rom"
-
# Override the default variant behavior, since the data.vbt is the same
# for all variants.
config INTEL_GMA_VBT_FILE
diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig
index cdba84ac8a..69cfdcccdd 100644
--- a/src/mainboard/google/stout/Kconfig
+++ b/src/mainboard/google/stout/Kconfig
@@ -30,10 +30,6 @@ config MAINBOARD_DIR
config MAINBOARD_PART_NUMBER
default "Stout"
-config VGA_BIOS_FILE
- string
- default "pci8086,0156.rom"
-
config VGA_BIOS_ID
string
default "8086,0156"