summaryrefslogtreecommitdiff
path: root/src/mainboard/google
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2019-08-16 14:02:25 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2019-08-18 19:03:22 +0000
commit157b189f6b97b6e9ecd8d29edbbd045fbbc231f5 (patch)
tree4562bd212e40d0832fa893935d85a06d82f8a897 /src/mainboard/google
parent146c09823333c52e8bbca98465ccc8512ec1daa2 (diff)
cpu/intel: Enter romstage without BIST
When entry to romstage is via cpu/intel/car/romstage.c BIST has not been passed down the path for sometime. Change-Id: I345975c53014902269cee21fc393331d33a84dce Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34908 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/beltino/romstage.c3
-rw-r--r--src/mainboard/google/slippy/romstage.c4
-rw-r--r--src/mainboard/google/slippy/variant.h2
-rw-r--r--src/mainboard/google/slippy/variants/falco/romstage.c3
-rw-r--r--src/mainboard/google/slippy/variants/leon/romstage.c3
-rw-r--r--src/mainboard/google/slippy/variants/peppy/romstage.c3
-rw-r--r--src/mainboard/google/slippy/variants/wolf/romstage.c3
7 files changed, 8 insertions, 13 deletions
diff --git a/src/mainboard/google/beltino/romstage.c b/src/mainboard/google/beltino/romstage.c
index 70a8c1928a..d36971fc39 100644
--- a/src/mainboard/google/beltino/romstage.c
+++ b/src/mainboard/google/beltino/romstage.c
@@ -67,7 +67,7 @@ const struct rcba_config_instruction rcba_config[] = {
RCBA_END_CONFIG,
};
-void mainboard_romstage_entry(unsigned long bist)
+void mainboard_romstage_entry(void)
{
struct pei_data pei_data = {
.pei_version = PEI_VERSION,
@@ -130,7 +130,6 @@ void mainboard_romstage_entry(unsigned long bist)
.pei_data = &pei_data,
.gpio_map = &mainboard_gpio_map,
.rcba_config = &rcba_config[0],
- .bist = bist,
};
/* Early SuperIO setup */
diff --git a/src/mainboard/google/slippy/romstage.c b/src/mainboard/google/slippy/romstage.c
index ec5d5ea138..3f6d989fd4 100644
--- a/src/mainboard/google/slippy/romstage.c
+++ b/src/mainboard/google/slippy/romstage.c
@@ -18,7 +18,7 @@
#include "variant.h"
-void mainboard_romstage_entry(unsigned long bist)
+void mainboard_romstage_entry(void)
{
- variant_romstage_entry(bist);
+ variant_romstage_entry();
}
diff --git a/src/mainboard/google/slippy/variant.h b/src/mainboard/google/slippy/variant.h
index eec024ed0e..87a228c89c 100644
--- a/src/mainboard/google/slippy/variant.h
+++ b/src/mainboard/google/slippy/variant.h
@@ -16,6 +16,6 @@
#ifndef VARIANT_H
#define VARIANT_H
-void variant_romstage_entry(unsigned long bist);
+void variant_romstage_entry(void);
#endif
diff --git a/src/mainboard/google/slippy/variants/falco/romstage.c b/src/mainboard/google/slippy/variants/falco/romstage.c
index 25f8d27ece..1903588816 100644
--- a/src/mainboard/google/slippy/variants/falco/romstage.c
+++ b/src/mainboard/google/slippy/variants/falco/romstage.c
@@ -105,7 +105,7 @@ static void copy_spd(struct pei_data *peid)
}
}
-void variant_romstage_entry(unsigned long bist)
+void variant_romstage_entry(void)
{
struct pei_data pei_data = {
.pei_version = PEI_VERSION,
@@ -167,7 +167,6 @@ void variant_romstage_entry(unsigned long bist)
.pei_data = &pei_data,
.gpio_map = &mainboard_gpio_map,
.rcba_config = &rcba_config[0],
- .bist = bist,
.copy_spd = copy_spd,
};
diff --git a/src/mainboard/google/slippy/variants/leon/romstage.c b/src/mainboard/google/slippy/variants/leon/romstage.c
index b95c6e1187..3ef8eec5df 100644
--- a/src/mainboard/google/slippy/variants/leon/romstage.c
+++ b/src/mainboard/google/slippy/variants/leon/romstage.c
@@ -102,7 +102,7 @@ static void copy_spd(struct pei_data *peid)
spd_file + (spd_index * spd_len), spd_len);
}
-void variant_romstage_entry(unsigned long bist)
+void variant_romstage_entry(void)
{
struct pei_data pei_data = {
.pei_version = PEI_VERSION,
@@ -162,7 +162,6 @@ void variant_romstage_entry(unsigned long bist)
.pei_data = &pei_data,
.gpio_map = &mainboard_gpio_map,
.rcba_config = &rcba_config[0],
- .bist = bist,
.copy_spd = copy_spd,
};
diff --git a/src/mainboard/google/slippy/variants/peppy/romstage.c b/src/mainboard/google/slippy/variants/peppy/romstage.c
index 37c7853347..71eafc2d7a 100644
--- a/src/mainboard/google/slippy/variants/peppy/romstage.c
+++ b/src/mainboard/google/slippy/variants/peppy/romstage.c
@@ -119,7 +119,7 @@ static void copy_spd(struct pei_data *peid)
}
}
-void variant_romstage_entry(unsigned long bist)
+void variant_romstage_entry(void)
{
struct pei_data pei_data = {
.pei_version = PEI_VERSION,
@@ -179,7 +179,6 @@ void variant_romstage_entry(unsigned long bist)
.pei_data = &pei_data,
.gpio_map = &mainboard_gpio_map,
.rcba_config = &rcba_config[0],
- .bist = bist,
.copy_spd = copy_spd,
};
diff --git a/src/mainboard/google/slippy/variants/wolf/romstage.c b/src/mainboard/google/slippy/variants/wolf/romstage.c
index 731b35748d..7fcf085455 100644
--- a/src/mainboard/google/slippy/variants/wolf/romstage.c
+++ b/src/mainboard/google/slippy/variants/wolf/romstage.c
@@ -106,7 +106,7 @@ static void copy_spd(struct pei_data *peid)
}
}
-void variant_romstage_entry(unsigned long bist)
+void variant_romstage_entry(void)
{
struct pei_data pei_data = {
.pei_version = PEI_VERSION,
@@ -166,7 +166,6 @@ void variant_romstage_entry(unsigned long bist)
.pei_data = &pei_data,
.gpio_map = &mainboard_gpio_map,
.rcba_config = &rcba_config[0],
- .bist = bist,
.copy_spd = copy_spd,
};