aboutsummaryrefslogtreecommitdiff
path: root/src/mainboard/google
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2022-12-19 15:15:13 -0600
committerMartin L Roth <gaumless@gmail.com>2022-12-22 20:42:33 +0000
commitf39e105debfdec3ca1db1aa1100d7c99451a528a (patch)
tree330887a584314eb88fec917d68ac5906ca295dfb /src/mainboard/google
parent148207a8b7173dab444a6b6ed9d16cb69458d0db (diff)
mb/google/kahlee: update ACPI HID/CID for Synaptics touchpads
The currently assigned ACPI HID 'PNP0C50' is not a valid per Windows WHQL validation tests. To ensure compatibility with both Windows and Linux, set the HID to 'SYNA0000' and CID to 'ACPI0C50' as previously done for other boards (eg, google/lulu). TEST=boot Linux 5.1x, Windows 10 on liara, verify all touchpad functions work correctly. Change-Id: I89ca02629803882e7ed2048a5a26868fc2de41a9 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71073 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/kahlee/variants/aleena/overridetree.cb3
-rw-r--r--src/mainboard/google/kahlee/variants/liara/overridetree.cb3
-rw-r--r--src/mainboard/google/kahlee/variants/nuwani/overridetree.cb3
-rw-r--r--src/mainboard/google/kahlee/variants/treeya/overridetree.cb3
4 files changed, 8 insertions, 4 deletions
diff --git a/src/mainboard/google/kahlee/variants/aleena/overridetree.cb b/src/mainboard/google/kahlee/variants/aleena/overridetree.cb
index e0f796e3ec..9fb09b2ab3 100644
--- a/src/mainboard/google/kahlee/variants/aleena/overridetree.cb
+++ b/src/mainboard/google/kahlee/variants/aleena/overridetree.cb
@@ -36,7 +36,8 @@ chip soc/amd/stoneyridge
device ref i2c_2 on
chip drivers/i2c/hid
- register "generic.hid" = ""PNP0C50""
+ register "generic.hid" = ""SYNA0000""
+ register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)"
register "generic.wake" = "7"
diff --git a/src/mainboard/google/kahlee/variants/liara/overridetree.cb b/src/mainboard/google/kahlee/variants/liara/overridetree.cb
index 7b1c2d37a6..b5256b5214 100644
--- a/src/mainboard/google/kahlee/variants/liara/overridetree.cb
+++ b/src/mainboard/google/kahlee/variants/liara/overridetree.cb
@@ -41,7 +41,8 @@ chip soc/amd/stoneyridge
end
device ref i2c_2 on
chip drivers/i2c/hid
- register "generic.hid" = ""PNP0C50""
+ register "generic.hid" = ""SYNA0000""
+ register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)"
register "generic.wake" = "7"
diff --git a/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb b/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb
index 0de9c9830c..ce00674b45 100644
--- a/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb
+++ b/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb
@@ -49,7 +49,8 @@ chip soc/amd/stoneyridge
device ref i2c_2 on
chip drivers/i2c/hid
- register "generic.hid" = ""PNP0C50""
+ register "generic.hid" = ""SYNA0000""
+ register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)"
register "generic.wake" = "7"
diff --git a/src/mainboard/google/kahlee/variants/treeya/overridetree.cb b/src/mainboard/google/kahlee/variants/treeya/overridetree.cb
index 69ffca3f53..9c4009e764 100644
--- a/src/mainboard/google/kahlee/variants/treeya/overridetree.cb
+++ b/src/mainboard/google/kahlee/variants/treeya/overridetree.cb
@@ -66,7 +66,8 @@ chip soc/amd/stoneyridge
end
device ref i2c_2 on
chip drivers/i2c/hid
- register "generic.hid" = ""PNP0C50""
+ register "generic.hid" = ""SYNA0000""
+ register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)"
register "generic.wake" = "7"