summaryrefslogtreecommitdiff
path: root/src/mainboard/google
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2022-12-21 14:20:23 -0600
committerMartin L Roth <gaumless@gmail.com>2023-01-02 20:40:18 +0000
commitdde327870882f1aea6bcfeee4b977e67262b2cb5 (patch)
treebc36622a19daf421f6484a0b9eae27bf6daadb90 /src/mainboard/google
parent631d77eca9fa60771ce71648e47f7918d6a2e397 (diff)
mb/google/drallion: Set touchpad/screen IRQs to LEVEL vs EDGE
The GPIOs themselves are configured as level triggered, and the drivers (both Linux and Windows) work better with LEVEL vs EDGE triggering. TEST=tested with rest of patch train Change-Id: I1bdbf017bc7480f59cec85c70d6e71dac294dcd2 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71192 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/mainboard/google')
-rw-r--r--src/mainboard/google/drallion/variants/drallion/devicetree.cb6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
index a9de097fc1..6001a86e7c 100644
--- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb
+++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
@@ -378,7 +378,7 @@ chip soc/intel/cannonlake
chip drivers/i2c/generic
register "hid" = ""MLFS0000""
register "desc" = ""Melfas Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)"
register "reset_delay_ms" = "10"
@@ -397,14 +397,14 @@ chip soc/intel/cannonlake
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"
register "detect" = "1"
device i2c 2c on end
end
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"
register "detect" = "1"
device i2c 15 on end
end