diff options
| author | Keith Hui <buurin@gmail.com> | 2023-03-20 02:03:47 -0400 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-03-23 15:14:45 +0000 |
| commit | c5d6af43fb544423fa103f523ac85356b3ff3725 (patch) | |
| tree | 8cf30f87ba30b1e3334b4546dddd69dbd8b2ffdd /src/mainboard/google | |
| parent | 0e1be046acaf5cfb9e2c41521270d137fa3423c5 (diff) | |
nb/intel/snb: Abolish mainboard_should_reset_usb()
Of the 13 mainboards that implement mainboard_should_reset_usb() hook,
all but one do the same: Stop MRC from resetting USB when resuming
from S3 suspend.
This hook turns out is only here to facilitate a USB reset workaround
on samsung/stumpy for an old ChromeOS kernel which is no longer needed.
Drop the workaround, the hook, and headers no longer used.
roda/rv11/early_init.c is left with no useful code after this patch,
so drop it entirely from both bootblock and romstage.
Change-Id: Ib3a5a00c0a6b1528e39435784919223d16b3914e
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72496
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/mainboard/google')
| -rw-r--r-- | src/mainboard/google/butterfly/early_init.c | 5 | ||||
| -rw-r--r-- | src/mainboard/google/link/early_init.c | 5 | ||||
| -rw-r--r-- | src/mainboard/google/parrot/early_init.c | 5 | ||||
| -rw-r--r-- | src/mainboard/google/stout/early_init.c | 5 |
4 files changed, 0 insertions, 20 deletions
diff --git a/src/mainboard/google/butterfly/early_init.c b/src/mainboard/google/butterfly/early_init.c index 073e7992f1..4e9639fd94 100644 --- a/src/mainboard/google/butterfly/early_init.c +++ b/src/mainboard/google/butterfly/early_init.c @@ -116,8 +116,3 @@ void mainboard_fill_pei_data(struct pei_data *pei_data) }; *pei_data = pei_data_template; } - -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} diff --git a/src/mainboard/google/link/early_init.c b/src/mainboard/google/link/early_init.c index d3209d0490..17e8b54b96 100644 --- a/src/mainboard/google/link/early_init.c +++ b/src/mainboard/google/link/early_init.c @@ -166,8 +166,3 @@ void mainboard_early_init(int s3resume) google_chromeec_kbbacklight(100); } } - -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} diff --git a/src/mainboard/google/parrot/early_init.c b/src/mainboard/google/parrot/early_init.c index f4769a1343..ba93531cb5 100644 --- a/src/mainboard/google/parrot/early_init.c +++ b/src/mainboard/google/parrot/early_init.c @@ -118,8 +118,3 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only) read_spd(&spd[0], 0x50, id_only); read_spd(&spd[2], 0x52, id_only); } - -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} diff --git a/src/mainboard/google/stout/early_init.c b/src/mainboard/google/stout/early_init.c index b33f57c205..e5ed8e91ac 100644 --- a/src/mainboard/google/stout/early_init.c +++ b/src/mainboard/google/stout/early_init.c @@ -144,11 +144,6 @@ void mainboard_early_init(int s3resume) } } -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} - const struct southbridge_usb_port mainboard_usb_ports[] = { /* enabled USB oc pin length */ {1, 0, 0}, /* P0: USB 3.0 1 (OC0) */ |