diff options
| author | Subrata Banik <subratabanik@google.com> | 2024-07-30 18:33:11 +0530 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2024-07-31 03:56:14 +0000 |
| commit | 8200a9ac387ca35d93b307ff01038d686c9281e4 (patch) | |
| tree | 1378dbbb578ef31ead809b342c91abbc06014e2e /src/mainboard/google | |
| parent | 42e4dd5aef69b3bb4962368317acac3e050a9e99 (diff) | |
mb/google/trulo: Keep ISH default enable
This patch drops fw_config probing for ISH because ISH IP should
remains on by default for all Trulo variants.
Additionally, removed the redundant ISH entries from variant
override devicetree.
BUG=b:354607924
TEST=Able to verify ISH PCI Device is available while booting eMMC sku.
```
lspci
00:00.0 Host bridge: Intel Corporation Device 461c
...
00:12.0 Serial controller: Intel Corporation Device 54fc
...
00:1a.0 SD Host controller: Intel Corporation Device 54c4
```
Also, able to enter S0ix with this patch.
```
> suspend_stress_test -c 1 --ignore_s0ix_substates
At AP console:
s0ix errors: 0
s0ix substate errors: 0
s0ix pc10 errors: 0
At EC console:
power state 5 = S0ix, in 0x38d87
```
Change-Id: Ic1e415ec848ac91a9bbf21b26597f4e6b5f7a1f5
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83695
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: V Sowmya <v.sowmya@intel.com>
Reviewed-by: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google')
3 files changed, 6 insertions, 16 deletions
diff --git a/src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb index f048dbba13..8e1093a120 100644 --- a/src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb @@ -45,6 +45,12 @@ chip soc/intel/alderlake device ref igpu on end device ref dtt on end device ref tcss_xhci on end + device ref ish on + chip drivers/intel/ish + register "add_acpi_dma_property" = "true" + device generic 0 on end + end + end device ref xhci on end device ref shared_sram on end device ref heci1 on end diff --git a/src/mainboard/google/brya/variants/orisa/overridetree.cb b/src/mainboard/google/brya/variants/orisa/overridetree.cb index 92909ab425..0a58b3d328 100644 --- a/src/mainboard/google/brya/variants/orisa/overridetree.cb +++ b/src/mainboard/google/brya/variants/orisa/overridetree.cb @@ -512,14 +512,6 @@ chip soc/intel/alderlake probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_EMMC end - device ref ish on - chip drivers/intel/ish - register "add_acpi_dma_property" = "true" - device generic 0 on end - end - probe STORAGE STORAGE_UNKNOWN - probe STORAGE STORAGE_UFS - end device ref ufs on probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_UFS diff --git a/src/mainboard/google/brya/variants/trulo/overridetree.cb b/src/mainboard/google/brya/variants/trulo/overridetree.cb index 3ae9f8523f..d7fca12307 100644 --- a/src/mainboard/google/brya/variants/trulo/overridetree.cb +++ b/src/mainboard/google/brya/variants/trulo/overridetree.cb @@ -518,14 +518,6 @@ chip soc/intel/alderlake probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_EMMC end - device ref ish on - chip drivers/intel/ish - register "add_acpi_dma_property" = "true" - device generic 0 on end - end - probe STORAGE STORAGE_UNKNOWN - probe STORAGE STORAGE_UFS - end device ref ufs on probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_UFS |