diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2021-04-15 01:04:06 +0200 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2021-04-29 15:31:53 +0000 |
| commit | 5db62ef94aaa6d9aa1b4d56494a5e95f06d5eb2e (patch) | |
| tree | c1325fb654ab88f887f8c3603202fce3a329af1f /src/mainboard/google | |
| parent | d6ace2457ec1203d52bb7b294fda397ec1399605 (diff) | |
mb/google/guybrush,mancomb: only print warning in mainboard_smi_gpi
guybrush and mancomb don't configure any GPIO as PAD_SMI. Since
mainboard_smi_gpi will only get called for a GEVENT that will cause a
non-SCI SMI, this isn't expected to be called. For the unexpected and
very unlikely case that it still does get called, put a printk into
mainboard_smi_gpi to see what is happening there.
TEST=none
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ifd6e3348ecc078932bf6cf5b0830b4b034d274bb
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52360
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google')
| -rw-r--r-- | src/mainboard/google/guybrush/smihandler.c | 4 | ||||
| -rw-r--r-- | src/mainboard/google/mancomb/smihandler.c | 4 |
2 files changed, 6 insertions, 2 deletions
diff --git a/src/mainboard/google/guybrush/smihandler.c b/src/mainboard/google/guybrush/smihandler.c index 6facb76476..04280db316 100644 --- a/src/mainboard/google/guybrush/smihandler.c +++ b/src/mainboard/google/guybrush/smihandler.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> +#include <console/console.h> #include <cpu/x86/smm.h> #include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/smm.h> @@ -9,7 +10,8 @@ void mainboard_smi_gpi(u32 gpi_sts) { - chromeec_smi_process_events(); + printk(BIOS_WARNING, "No GPIO is set up as PAD_SMI, so %s should never end up being " + "called. gpi_status is %x.\n", __func__, gpi_sts); } void mainboard_smi_sleep(u8 slp_typ) diff --git a/src/mainboard/google/mancomb/smihandler.c b/src/mainboard/google/mancomb/smihandler.c index 6facb76476..04280db316 100644 --- a/src/mainboard/google/mancomb/smihandler.c +++ b/src/mainboard/google/mancomb/smihandler.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> +#include <console/console.h> #include <cpu/x86/smm.h> #include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/smm.h> @@ -9,7 +10,8 @@ void mainboard_smi_gpi(u32 gpi_sts) { - chromeec_smi_process_events(); + printk(BIOS_WARNING, "No GPIO is set up as PAD_SMI, so %s should never end up being " + "called. gpi_status is %x.\n", __func__, gpi_sts); } void mainboard_smi_sleep(u8 slp_typ) |