aboutsummaryrefslogtreecommitdiff
path: root/src/mainboard/google/zork/spd/Makefile.inc
diff options
context:
space:
mode:
authorRob Barnes <robbarnes@google.com>2020-08-14 15:34:24 -0600
committerAaron Durbin <adurbin@chromium.org>2020-08-28 15:58:34 +0000
commit55ccd5b873eca356a4f20163aa0231320508e0f7 (patch)
treec08118264c1d94ef683993af81a8e86e7b4887dd /src/mainboard/google/zork/spd/Makefile.inc
parent8da998c2b084235181b9b2cd2d4a7ac15a92c4a1 (diff)
mb/google/zork: Switch zork to use spd_tools
Switch all zork boards to use generated generic SPDs from spd_tools. HMAA1GS6CMR6N-VK is unused by Ezkinil, and all other boards, so it was removed. picasso/Makefile.inc was updated to populate the 2nd APCB channel based on APCB_POPULATE_2ND_CHANNEL. This removes the need to suffix spd entires with _x1/_x2. Command to generate files: $ find src/mainboard/google/zork/variants/ -maxdepth 1 -type d | grep -v '/$' | while read b; do n=$(basename ${b}); if [ "${n}" = "baseboard" ]; then continue fi go run util/spd_tools/ddr4/gen_part_id.go src/mainboard/google/zork/spd \ src/mainboard/google/zork/variants/${n}/spd \ src/mainboard/google/zork/variants/${n}/spd/mem_parts_used.txt done BUG=b:162939176 TEST=Boot ezkinil and dalboz check dmidecod -t17 Signed-off-by: Rob Barnes <robbarnes@google.com> Change-Id: I0553858f83d3d1e90cf35bece108768f004a29a5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44480 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/zork/spd/Makefile.inc')
-rw-r--r--src/mainboard/google/zork/spd/Makefile.inc25
1 files changed, 0 insertions, 25 deletions
diff --git a/src/mainboard/google/zork/spd/Makefile.inc b/src/mainboard/google/zork/spd/Makefile.inc
index e401fa6fdc..66957d82c2 100644
--- a/src/mainboard/google/zork/spd/Makefile.inc
+++ b/src/mainboard/google/zork/spd/Makefile.inc
@@ -2,28 +2,3 @@
# This directory
SPD_SOURCES_DIR := src/mainboard/$(MAINBOARDDIR)/spd
-
-# Ordered List of APCB entries, up to 16.
-# Entries should match this pattern {NAME}_x{1,2}
-# There should be a matching SPD hex file in SPD_SOURCES_DIR
-# matching the pattern {NAME}.spd.hex
-# The _x{1,2} suffix denotes single or dual channel
-# TODO: Remove channel suffix when b:141434940 is fixed
-# Alternatively, generated APCBs stored at
-# 3rdparty/blobs/mainboard/$(MAINBOARDDIR)/APCB_{NAME}.bin will be included.
-APCB_SOURCES = hynix-H5AN8G6NCJR-VKC_x1 # 0b0000
-APCB_SOURCES += hynix-H5ANAG6NCMR-VKC_x2 # 0b0001
-APCB_SOURCES += empty # 0b0010
-APCB_SOURCES += empty # 0b0011
-APCB_SOURCES += empty # 0b0100
-APCB_SOURCES += empty # 0b0101
-APCB_SOURCES += empty # 0b0110
-APCB_SOURCES += empty # 0b0111
-APCB_SOURCES += empty # 0b1000
-APCB_SOURCES += empty # 0b1001
-APCB_SOURCES += empty # 0b1010
-APCB_SOURCES += empty # 0b1011
-APCB_SOURCES += empty # 0b1100
-APCB_SOURCES += empty # 0b1101
-APCB_SOURCES += empty # 0b1110
-APCB_SOURCES += empty # 0b1111