summaryrefslogtreecommitdiff
path: root/src/mainboard/google/volteer
diff options
context:
space:
mode:
authorAlex Levin <levinale@chromium.org>2020-05-12 21:24:23 -0700
committerAaron Durbin <adurbin@chromium.org>2020-05-15 04:32:41 +0000
commit9e8dd06cd4adc8c5bae267251d3a5532737d05e4 (patch)
treee0d969751be37ead38a26f15e4274cd68d9e4348 /src/mainboard/google/volteer
parentecc4c4e5f141543daa6c96826f3e6b5dcfa2a554 (diff)
mb/google/volteer: Add delay to WWAN GPIO init sequence
Based on Fibocom HW user manual RESET should be deasserted at least 20ms after the power on pin. The design for the reset pin is open drain connected to a pull up, so it is set to high-Z (configured as GPIO in) after 20ms. BUG=b:152013143 BRANCH=none TEST=traced the signals using a scope to verify timing is met. Signed-off-by: Alex Levin <levinale@chromium.org> Change-Id: I7c947d1bc4cce1f97383a2f2c254986e182661c5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41356 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/volteer')
-rw-r--r--src/mainboard/google/volteer/variants/baseboard/gpio.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c
index 2fbfced1a9..bff7e3c3ad 100644
--- a/src/mainboard/google/volteer/variants/baseboard/gpio.c
+++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c
@@ -265,10 +265,8 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPP_F9, NONE),
/* F10 : GPPF10_STRAP */
PAD_NC(GPP_F10, DN_20K),
- /* F11 : THC1_SPI2_CLK ==> EN_PP3300_WWAN */
- PAD_CFG_GPO(GPP_F11, 1, DEEP),
/* F12 : GSXDOUT ==> WWAN_RST_ODL */
- PAD_CFG_GPO(GPP_F12, 1, DEEP),
+ PAD_CFG_GPI(GPP_F12, NONE, DEEP),
/* F13 : GSXDOUT ==> WiFi_DISABLE_L */
PAD_CFG_GPO(GPP_F13, 1, DEEP),
/* F14 : GSXDIN ==> SAR0_INT_L */
@@ -435,6 +433,14 @@ static const struct pad_config early_gpio_table[] = {
/* E12 : SPI1_MISO_IO1 ==> EN_PP3300_SSD */
PAD_CFG_GPO(GPP_E12, 1, DEEP),
+ /* F11 : THC1_SPI2_CLK ==> EN_PP3300_WWAN */
+ PAD_CFG_GPO(GPP_F11, 1, DEEP),
+
+ /* F12 : GSXDOUT ==> WWAN_RST_ODL
+ To meet timing constrains - drive reset low.
+ Deasserted in ramstage. */
+ PAD_CFG_GPO(GPP_F12, 0, DEEP),
+
/* H11 : SRCCLKREQ5# ==> WLAN_PERST_L */
PAD_CFG_GPO(GPP_H11, 1, DEEP),
};