summaryrefslogtreecommitdiff
path: root/src/mainboard/google/volteer
diff options
context:
space:
mode:
authorNick Vaccaro <nvaccaro@google.com>2020-03-10 00:23:40 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-03-15 12:52:54 +0000
commitaeaeeb7687d657a3f6d71a63ba717af2f14f3bad (patch)
treeb298739a4088e818599ae207b3e5e805476d3cc0 /src/mainboard/google/volteer
parentee47fe42f57b47c5fa301966bbb709abc775f66c (diff)
mb/google/volteer: Use generic SPD files
Volteer uses 4 bits (hardware straps) to indicate what memory configuration the board is populated with (i.e. which SPD file to use for the populated memory). This allows for only 16 different SPDs for supporting Volteer and all future variants of Volteer. Currently, each memory chip needs its own SPD file, so we can only support 16 different memory chip options for Volteer and all of its variants. Generic SPD files are just SPD files that have been stripped down to contain only fields that are important for the memory controller (strips out items like vendor info, for example). Using generic SPD files allows for more than 16 different memory options given it's no longer a 1-to-1 mapping as similar memory modules from different vendors can share the same generic SPD file. BUG=b:147857288 TEST="emerge-volteer coreboot chromeos-bootimage", flash ripto and verify ripto boots to kernel and "cat /proc/meminfo" reports 8GB of memory. Change-Id: I17bd4f4a00b4e3bbaf845d6d321962c11569a186 Signed-off-by: Nick Vaccaro <nvaccaro@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39423 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/volteer')
-rw-r--r--src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_8bank_1Rx16_16Gb_DDP_4267.spd.hex (renamed from src/mainboard/google/volteer/spd/samsung-K4U6E3S4AA-MGCL.spd.hex)8
-rw-r--r--src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_8bank_2Rx16_32Gb_DDP_4267.spd.hex (renamed from src/mainboard/google/volteer/spd/samsung-K4UBE3D4AA-MGCR.spd.hex)6
-rw-r--r--src/mainboard/google/volteer/variants/ripto/Makefile.inc2
-rw-r--r--src/mainboard/google/volteer/variants/volteer/Makefile.inc4
4 files changed, 10 insertions, 10 deletions
diff --git a/src/mainboard/google/volteer/spd/samsung-K4U6E3S4AA-MGCL.spd.hex b/src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_8bank_1Rx16_16Gb_DDP_4267.spd.hex
index e1f27fba56..a94b41a381 100644
--- a/src/mainboard/google/volteer/spd/samsung-K4U6E3S4AA-MGCL.spd.hex
+++ b/src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_8bank_1Rx16_16Gb_DDP_4267.spd.hex
@@ -1,5 +1,5 @@
-23 11 11 0E 15 19 95 08 00 40 00 00 02 21 00 00
-48 00 04 FF 92 55 00 00 8C 00 90 A8 90 C0 08 60
+23 11 11 0E 15 19 95 08 00 00 00 00 02 21 00 00
+48 00 04 00 92 55 00 00 8C 00 90 A8 90 C0 08 60
04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
@@ -18,8 +18,8 @@
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 20 00 00 00 20 20 20 20 20 20 20
-20 20 20 20 20 20 20 20 20 20 20 20 20 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/volteer/spd/samsung-K4UBE3D4AA-MGCR.spd.hex b/src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_8bank_2Rx16_32Gb_DDP_4267.spd.hex
index 945b2e8e06..7ef8220252 100644
--- a/src/mainboard/google/volteer/spd/samsung-K4UBE3D4AA-MGCR.spd.hex
+++ b/src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_8bank_2Rx16_32Gb_DDP_4267.spd.hex
@@ -1,5 +1,5 @@
23 11 11 0E 15 21 B5 08 00 40 00 00 0A 21 00 00
-48 00 04 0F 92 54 05 00 87 00 90 A8 90 C0 08 60
+48 00 04 00 92 54 05 00 87 00 90 A8 90 C0 08 60
04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
@@ -18,8 +18,8 @@
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-00 00 00 00 00 20 00 00 00 20 20 20 20 20 20 20
-20 20 20 20 20 20 20 20 20 20 20 20 20 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/volteer/variants/ripto/Makefile.inc b/src/mainboard/google/volteer/variants/ripto/Makefile.inc
index 95401499f7..eba064ff1b 100644
--- a/src/mainboard/google/volteer/variants/ripto/Makefile.inc
+++ b/src/mainboard/google/volteer/variants/ripto/Makefile.inc
@@ -13,7 +13,7 @@
## GNU General Public License for more details.
##
-SPD_SOURCES = samsung-K4U6E3S4AA-MGCL # 0b0000
+SPD_SOURCES = SPD_LPDDR4X_200b_8bank_1Rx16_16Gb_DDP_4267 # 0b0000
bootblock-y += gpio.c
diff --git a/src/mainboard/google/volteer/variants/volteer/Makefile.inc b/src/mainboard/google/volteer/variants/volteer/Makefile.inc
index a6659db315..3f3f6d5f78 100644
--- a/src/mainboard/google/volteer/variants/volteer/Makefile.inc
+++ b/src/mainboard/google/volteer/variants/volteer/Makefile.inc
@@ -7,5 +7,5 @@
##
## Memory Options
-SPD_SOURCES = samsung-K4U6E3S4AA-MGCL # 0b0000
-SPD_SOURCES += samsung-K4UBE3D4AA-MGCR # 0b0001
+SPD_SOURCES = SPD_LPDDR4X_200b_8bank_1Rx16_16Gb_DDP_4267 # 0b0000
+SPD_SOURCES += SPD_LPDDR4X_200b_8bank_2Rx16_32Gb_DDP_4267 # 0b0001