diff options
| author | Paul Fagerburg <pfagerburg@google.com> | 2021-02-09 13:04:55 -0700 |
|---|---|---|
| committer | Paul Fagerburg <pfagerburg@chromium.org> | 2021-02-10 22:15:52 +0000 |
| commit | 259cccd7e7faf23047b9fe9fb551f27c8fd4ee27 (patch) | |
| tree | f59f9701214a67d1fae37cf1f33b70e18631f7ae /src/mainboard/google/volteer/variants | |
| parent | 237bc2efaa2e31378dee11fcbd1e0b0e26064573 (diff) | |
mb/google: order matters in mem_parts_used.txt
* Add comments to mem_parts_used.txt to point out that the order of
the entries matters when assigning IDs, so always add a new part
to the end of the file.
* Update existing mem_parts_used.txt to add the same comment.
* No updates to Zork variants, because they use an optional ID, so
the order actually doesn't matter there.
BUG=b:175898902
TEST=create a new variant of dalboz, trembyle, volteer, waddledee,
or waddledoo, and observe that mem_parts_used.txt has the new
verbiage.
Signed-off-by: Paul Fagerburg <pfagerburg@google.com>
Change-Id: Iffbd8e69a89b1b7c810c5d25c7a6148d459d8b02
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50449
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Diffstat (limited to 'src/mainboard/google/volteer/variants')
| -rw-r--r-- | src/mainboard/google/volteer/variants/copano/memory/mem_parts_used.txt | 9 | ||||
| -rw-r--r-- | src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt | 11 |
2 files changed, 19 insertions, 1 deletions
diff --git a/src/mainboard/google/volteer/variants/copano/memory/mem_parts_used.txt b/src/mainboard/google/volteer/variants/copano/memory/mem_parts_used.txt index f51b3af398..e4258b530d 100644 --- a/src/mainboard/google/volteer/variants/copano/memory/mem_parts_used.txt +++ b/src/mainboard/google/volteer/variants/copano/memory/mem_parts_used.txt @@ -1,4 +1,11 @@ # This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Generated IDs are dependent on the order of parts in this file, +# so new parts must always be added at the end of the file! +# # Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/ddr4 or util/spd_tools/lp4x +# gen_part_id tool from util/spd_tools/{ddr4,lp4x}. # See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. + +# Part Name diff --git a/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt b/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt index c74fe433ba..76eab92b35 100644 --- a/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt +++ b/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt @@ -1,3 +1,14 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Generated IDs are dependent on the order of parts in this file, +# so new parts must always be added at the end of the file! +# +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/{ddr4,lp4x}. +# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. + +# Part Name MT53E512M64D4NW-046 WT:E MT53E1G64D8NW-046 WT:E H9HCNNNCRMBLPR-NEE |