aboutsummaryrefslogtreecommitdiff
path: root/src/mainboard/google/volteer/variants/malefor
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@google.com>2020-07-29 16:33:10 -0700
committerTim Wawrzynczak <twawrzynczak@chromium.org>2020-10-10 00:19:24 +0000
commitb0e169ac854d74fe267c00eb160c482c7d5e6dfd (patch)
tree95a15643c42575422b6649adce32358cf91deb62 /src/mainboard/google/volteer/variants/malefor
parenta5bb31f069d709f2ca9ddda4f623147df9653990 (diff)
mb/google/volteer: Use device aliases
Use the device aliases provided by tigerlake chipset.cb instead of the raw pci device+function. Take advantage of the default states in chipset.cb and only list the devices that are enabled for all volteer variants. Change-Id: I5620004afd7fa4d50389f32dd79148960a2b2662 Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44039 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/volteer/variants/malefor')
-rw-r--r--src/mainboard/google/volteer/variants/malefor/overridetree.cb29
1 files changed, 15 insertions, 14 deletions
diff --git a/src/mainboard/google/volteer/variants/malefor/overridetree.cb b/src/mainboard/google/volteer/variants/malefor/overridetree.cb
index 1dc6c2bff9..64b15b3dcc 100644
--- a/src/mainboard/google/volteer/variants/malefor/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/malefor/overridetree.cb
@@ -26,11 +26,12 @@ chip soc/intel/tigerlake
}"
device domain 0 on
- device pci 07.0 off end # TBT_PCIe0 0x9A23
- device pci 07.1 off end # TBT_PCIe1 0x9A25
- device pci 07.2 off end # TBT_PCIe2 0x9A27
- device pci 07.3 off end # TBT_PCIe3 0x9A29
- device pci 15.0 on
+ # Baseboard has these on, so they must be disabled here.
+ device ref tbt_pcie_rp0 off end
+ device ref tbt_pcie_rp1 off end
+ device ref tbt_dma0 off end
+
+ device ref i2c0 on
chip drivers/i2c/generic
register "hid" = ""10EC5682""
register "name" = ""RT58""
@@ -43,8 +44,8 @@ chip soc/intel/tigerlake
register "property_list[0].integer" = "1"
device i2c 1a on end
end
- end # I2C0
- device pci 15.1 on
+ end
+ device ref i2c1 on
chip drivers/i2c/hid
register "generic.hid" = ""GDIX0000""
register "generic.desc" = ""Goodix Touchscreen""
@@ -61,8 +62,8 @@ chip soc/intel/tigerlake
register "hid_desc_reg_offset" = "0x01"
device i2c 5d on end
end
- end # I2C1
- device pci 15.2 on
+ end
+ device ref i2c3 on
chip drivers/i2c/sx9310
register "desc" = ""SAR0 Proximity Sensor""
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_F14_IRQ)"
@@ -93,8 +94,8 @@ chip soc/intel/tigerlake
register "reg_sar_ctrl2" = "0x3c"
device i2c 28 on end
end
- end # I2C2 0xA0EA
- device pci 19.1 on
+ end
+ device ref i2c5 on
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
@@ -103,14 +104,14 @@ chip soc/intel/tigerlake
register "probed" = "1"
device i2c 15 on end
end
- end # I2C5 0xA0C6
- device pci 1f.3 on
+ end
+ device ref hda on
chip drivers/generic/max98357a
register "hid" = ""MX98357A""
register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)"
register "sdmode_delay" = "5"
device generic 0 on end
end
- end # Intel HD audio
+ end
end
end