diff options
| author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2020-12-09 10:11:06 -0700 |
|---|---|---|
| committer | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2020-12-11 16:59:49 +0000 |
| commit | 2f917e6cee275eda6bd620cb3dbf2ebf17173ed9 (patch) | |
| tree | 77659b9333296af404a6b7eac9fbee2688b44abf /src/mainboard/google/volteer/mainboard.c | |
| parent | 17689367d5ed24f20145f8a68414d34da039bb79 (diff) | |
mb/google/volteer: Clean up romstage and ramstage UPDs
Move the manual calls to fw_config_probe() into the devicetree; the
AUDIO probe is trivial, and the TCSS devices (DMA0, iTBT RP0 & RP1) are
already guarded with probe statements in the baseboard devicetree, so
the code in romstage.c was redundant. The variants seem to have their
USB4 probe statements correct as well, so the manual UPD setting in
mainboard.c was also unnecessary.
BUG=none
TEST=abuild google/volteer
Change-Id: I1d067ff3d181b152c784634ff99202bb2b9202f7
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48512
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/mainboard/google/volteer/mainboard.c')
| -rw-r--r-- | src/mainboard/google/volteer/mainboard.c | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/src/mainboard/google/volteer/mainboard.c b/src/mainboard/google/volteer/mainboard.c index 1f20e18ec7..4d65245066 100644 --- a/src/mainboard/google/volteer/mainboard.c +++ b/src/mainboard/google/volteer/mainboard.c @@ -165,20 +165,6 @@ static void mainboard_chip_init(void *chip_info) } } -void mainboard_silicon_init_params(FSP_S_CONFIG *params) -{ - bool has_usb4; - - /* If device doesn't have USB4 hardware, disable tbt */ - has_usb4 = (fw_config_probe(FW_CONFIG(DB_USB, USB4_GEN2)) - || fw_config_probe(FW_CONFIG(DB_USB, USB4_GEN3))); - - if (!has_usb4) - memset(params->ITbtPcieRootPortEn, 0, - ARRAY_SIZE(params->ITbtPcieRootPortEn) - * sizeof(*params->ITbtPcieRootPortEn)); -} - struct chip_operations mainboard_ops = { .init = mainboard_chip_init, .enable_dev = mainboard_enable, |