diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2020-07-04 01:24:59 +0200 |
|---|---|---|
| committer | Angel Pons <th3fanbus@gmail.com> | 2020-07-12 11:16:12 +0000 |
| commit | 8aab7876d186ed9a8e978ec06a83a46f74a6179b (patch) | |
| tree | 5069b7aa81401f9606021cc8e25f9d52192f7ea7 /src/mainboard/google/slippy | |
| parent | 39a6093d7937dec85077f754fbcaa2e2be493eae (diff) | |
haswell: Move some MRC settings to devicetree
There's no generic way to tell whether a mainboard has an EC or not.
Making Kconfig symbols for these options seems overkill, too. So, just
put them on the devicetree. Also, drop unnecessary assignments when the
board's current value is zero, as the struct defaults to zero already.
Change-Id: If2ebac5fcab278c97dfaf8adc9d1e125888acafe
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43129
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Tristan Corrick <tristan@corrick.kiwi>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/slippy')
| -rw-r--r-- | src/mainboard/google/slippy/devicetree.cb | 4 | ||||
| -rw-r--r-- | src/mainboard/google/slippy/romstage.c | 3 |
2 files changed, 4 insertions, 3 deletions
diff --git a/src/mainboard/google/slippy/devicetree.cb b/src/mainboard/google/slippy/devicetree.cb index 3d98d745a3..e22a41ebc2 100644 --- a/src/mainboard/google/slippy/devicetree.cb +++ b/src/mainboard/google/slippy/devicetree.cb @@ -14,6 +14,10 @@ chip northbridge/intel/haswell # Set backlight PWM value for eDP register "gpu_pch_backlight_pwm_hz" = "200" + register "ec_present" = "true" + + register "usb_xhci_on_resume" = "true" + device cpu_cluster 0 on chip cpu/intel/haswell device lapic 0 on end diff --git a/src/mainboard/google/slippy/romstage.c b/src/mainboard/google/slippy/romstage.c index 47bcb477f5..7f08a58aca 100644 --- a/src/mainboard/google/slippy/romstage.c +++ b/src/mainboard/google/slippy/romstage.c @@ -49,8 +49,5 @@ void mb_get_spd_map(uint8_t spd_map[4]) void mainboard_fill_pei_data(struct pei_data *pei_data) { - pei_data->ec_present = 1; - pei_data->usb_xhci_on_resume = 1; - variant_romstage_entry(pei_data); } |