summaryrefslogtreecommitdiff
path: root/src/mainboard/google/poppy
diff options
context:
space:
mode:
authorJacob Garber <jgarber1@ualberta.ca>2019-05-31 14:43:19 -0600
committerPatrick Georgi <pgeorgi@google.com>2019-06-03 13:18:11 +0000
commit38b7445ad240f7504b95e3e0c63122418e3ff159 (patch)
treea337e72acc083890cb3fbf60f736ede0c8edf346 /src/mainboard/google/poppy
parentd44d4f0f4eca026f81a3b2a21518d7524235f144 (diff)
mb/google/poppy/variants/nami: Add fallthrough comment
This fallthrough is intentional (see commit 2257a35862 - Perform PL2 setting for syndra), so add a comment to make that explicit. Change-Id: I57fe1e08f59aed12544cd2a71f1e0464f432f03b Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Found-by: Coverity CID 1397063 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33156 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/mainboard/google/poppy')
-rw-r--r--src/mainboard/google/poppy/variants/nami/mainboard.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c
index cc87136520..23870175b7 100644
--- a/src/mainboard/google/poppy/variants/nami/mainboard.c
+++ b/src/mainboard/google/poppy/variants/nami/mainboard.c
@@ -252,6 +252,7 @@ void variant_devtree_update(void)
case SKU_6_SYNDRA:
case SKU_7_SYNDRA:
pl2_id = PL2_ID_SONA_SYNDRA;
+ /* fallthrough */
case SKU_0_VAYNE:
case SKU_1_VAYNE:
case SKU_2_VAYNE: