diff options
| author | Eric Lai <ericr_lai@compal.corp-partner.google.com> | 2021-03-05 20:14:08 +0800 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2021-03-09 03:38:47 +0000 |
| commit | c03ab47dc473b0533fd0c6e695e501504f013497 (patch) | |
| tree | c756aeed83950c6d772faea3595aa8a4eb49d8b0 /src/mainboard/google/octopus | |
| parent | 8e6059db28491249954df81ba3baa593395be97a (diff) | |
mb/google/octopus/var/fleex: Only check LTE sku on fleex
Fleex has other project share the same FW. Only fleex has LTE sku.
So we need to make sure it is fleex then check if LTE sku.
BUG=b:181946744
BRANCH=octopus
TEST=Check no SAR table can be loaded with sku id 4 and 5.
Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
Change-Id: I9f3d5fed4315fc716acad1a07735221d154c377e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51288
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marco Chen <marcochen@google.com>
Reviewed-by: Henry Sun <henrysun@google.com>
Diffstat (limited to 'src/mainboard/google/octopus')
| -rw-r--r-- | src/mainboard/google/octopus/variants/fleex/variant.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/mainboard/google/octopus/variants/fleex/variant.c b/src/mainboard/google/octopus/variants/fleex/variant.c index 5554fb3388..6333b074dd 100644 --- a/src/mainboard/google/octopus/variants/fleex/variant.c +++ b/src/mainboard/google/octopus/variants/fleex/variant.c @@ -7,10 +7,17 @@ #include <soc/intel/apollolake/chip.h> #define MIN_LTE_SKU 4 +#define FLEEX_MAX_SKU 0x20 static bool is_lte_sku(void) { - return (google_chromeec_get_board_sku() >= MIN_LTE_SKU); + uint32_t sku_id = google_chromeec_get_board_sku(); + + /* Only Fleex has LTE sku */ + if (sku_id <= FLEEX_MAX_SKU) + return (sku_id >= MIN_LTE_SKU); + + return false; } void variant_smi_sleep(u8 slp_typ) |