aboutsummaryrefslogtreecommitdiff
path: root/src/mainboard/google/hatch/variants/dratini
diff options
context:
space:
mode:
authorEdward O'Callaghan <quasisec@google.com>2019-12-23 18:14:23 +1100
committerEdward O'Callaghan <quasisec@chromium.org>2019-12-24 00:08:42 +0000
commitb4177865254742fa7cb675a913a0c5c078cf5968 (patch)
tree35ddad88192de4bc8f25fc87f03b8c2849fd936e /src/mainboard/google/hatch/variants/dratini
parent295fdbef392e1ab6c8c7e4f0d7a9a01d95bb5bd5 (diff)
mainboard/google/hatch: Remove MAX98357A assumption from baseboard
Generally work towards a more loose baseboard definition by moving out some original assumptions to be board specifics. Specifically Puff does not have the MAX98357A speaker amp and enabling the driver winds up generating incorrect SSDT tables that confuse the kernel. Since devicetree inherits the chip from device node in base and an override will also inherit the chip and thus dispatch the unwanted fill_ssdt fn call. V.2: lean on linker to drop max98357a driver when not in dt. BRANCH=none BUG=b:146519004 TEST=./util/abuild/abuild -p none -t google/hatch -x -a Change-Id: I8e7fed69a4c6d9610ac100da6bae147828ebfa81 Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37909 Reviewed-by: Daniel Kurtz <djkurtz@google.com> Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/hatch/variants/dratini')
-rw-r--r--src/mainboard/google/hatch/variants/dratini/overridetree.cb7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
index 564a14d93c..c6a9ed70e3 100644
--- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
@@ -157,6 +157,13 @@ chip soc/intel/cannonlake
device spi 1 on end
end # FPMCU
end # GSPI #1
+ device pci 1f.3 on
+ chip drivers/generic/max98357a
+ register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H3)"
+ register "sdmode_delay" = "5"
+ device generic 0 on end
+ end
+ end # Intel HDA
end
end