aboutsummaryrefslogtreecommitdiff
path: root/src/mainboard/google/hatch/bootblock.c
diff options
context:
space:
mode:
authorMichael Niewöhner <foss@mniewoehner.de>2020-12-21 03:46:58 +0100
committerMichael Niewöhner <foss@mniewoehner.de>2021-01-21 17:52:06 +0000
commit3a2d4000cefe2f054a4ad53f95e06e6cbc86b5fc (patch)
treef577ae900e99147762eada674287b1780e125686 /src/mainboard/google/hatch/bootblock.c
parent1b77a487d6161053c36b5eeade3775b6858fb6ab (diff)
mb/google/hatch: do UART pad configuration at board-level
UART pad configuration should not be done in common code, because that may cause short circuits, when the user sets a wrong UART index. Thus, add the corresponding pads to the early UART gpio table for the board as a first step. Common UART pad config code then gets dropped in CB:48829. Also switch to `bootblock_mainboard_early_init` to configure the pads in early bootblock before console initialization, to make the console work as early as possible. The board does not do any other gpio configuration in bootblock, so this should not influence behaviour in a negative way (e.g. breaking overrides). Change-Id: I62ffbe36bd7b7675aa0f41a8c6e9214d04ad4ae5 Signed-off-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49428 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/hatch/bootblock.c')
-rw-r--r--src/mainboard/google/hatch/bootblock.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/mainboard/google/hatch/bootblock.c b/src/mainboard/google/hatch/bootblock.c
index 041ffcffd2..6e2f34d10e 100644
--- a/src/mainboard/google/hatch/bootblock.c
+++ b/src/mainboard/google/hatch/bootblock.c
@@ -4,7 +4,7 @@
#include <bootblock_common.h>
#include <soc/gpio.h>
-static void early_config_gpio(void)
+void bootblock_mainboard_early_init(void)
{
const struct pad_config *variant_early_table;
size_t variant_gpios;
@@ -12,8 +12,3 @@ static void early_config_gpio(void)
variant_early_table = variant_early_gpio_table(&variant_gpios);
gpio_configure_pads(variant_early_table, variant_gpios);
}
-
-void bootblock_mainboard_init(void)
-{
- early_config_gpio();
-}