diff options
| author | Furquan Shaikh <furquan@google.com> | 2020-05-21 23:53:07 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-05-28 09:26:15 +0000 |
| commit | 1fcb238d6262acfccd4f6ef68d100d812c2831b2 (patch) | |
| tree | a423e40f7bd865bd21e18ea771406de64a1f22a9 /src/mainboard/google/hatch/Kconfig | |
| parent | 45761c5e998316ba37c84fa1d26ba7ccde5ca7d8 (diff) | |
mb/google/hatch: Split Kconfigs into BASEBOARD_HATCH and BASEBOARD_PUFF
mb/google/hatch supports two different reference platforms - Hatch and
Puff. This change adds Kconfigs BOARD_GOOGLE_BASEBOARD_PUFF in
addition to BOARD_GOOGLE_BASEBOARD_HATCH to better organize the
Kconfig selections and reduce redundancy. In addition to this, a new
config BOARD_GOOGLE_HATCH_COMMON is added that selects all the common
configs for both baseboards.
TEST=Verified using abuild --timeless option that all hatch variants
generate the same coreboot.rom image with and without this change.
Change-Id: I46f8b2ed924c10228fa55e5168bf4fe6b41ec36c
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41660
Reviewed-by: V Sowmya <v.sowmya@intel.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/hatch/Kconfig')
| -rw-r--r-- | src/mainboard/google/hatch/Kconfig | 34 |
1 files changed, 18 insertions, 16 deletions
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index fc4424bd47..d36c152f04 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -1,6 +1,22 @@ config BOARD_GOOGLE_BASEBOARD_HATCH def_bool n + select BOARD_GOOGLE_HATCH_COMMON + select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE + select SYSTEM_TYPE_LAPTOP + select VBOOT_LID_SWITCH + +config BOARD_GOOGLE_BASEBOARD_PUFF + def_bool n + select BOARD_GOOGLE_HATCH_COMMON + select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE + select ROMSTAGE_SPD_SMBUS + select SPD_READ_BY_WORD + +config BOARD_GOOGLE_HATCH_COMMON + def_bool n select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_DA7219 @@ -22,15 +38,8 @@ config BOARD_GOOGLE_BASEBOARD_HATCH select MAINBOARD_HAS_TPM2 select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE select SOC_INTEL_COMETLAKE - select RT8168_GET_MAC_FROM_VPD - select RT8168_SET_LED_MODE - -config BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP - select BOARD_GOOGLE_BASEBOARD_HATCH - select SYSTEM_TYPE_LAPTOP - def_bool n -if BOARD_GOOGLE_BASEBOARD_HATCH +if BOARD_GOOGLE_HATCH_COMMON config CHROMEOS bool @@ -157,11 +166,4 @@ config VBOOT select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN select VBOOT_EARLY_EC_SYNC -endif # BOARD_GOOGLE_BASEBOARD_HATCH - -if BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP - -config VBOOT - select VBOOT_LID_SWITCH - -endif # BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP +endif # BOARD_GOOGLE_HATCH_COMMON |