diff options
| author | Joel Kitching <kitching@google.com> | 2019-03-23 12:41:04 +0800 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-03-27 08:21:01 +0000 |
| commit | 2e1f65545f7ee826322aef6a586a2580a23db775 (patch) | |
| tree | 9bb929c38b2b738a5fa4f517f185f7be9ff08304 /src/mainboard/google/foster | |
| parent | f7f41a663f11f57a463177d4f7c9df165830c821 (diff) | |
chromeos: update old boards to use lb_add_gpios notation
Instead of manually filling out the lb_gpios struct,
use the newer lb_add_gpios notation, which is more
compact and less error-prone.
BUG=b:124141368
TEST=util/lint/checkpatch.pl -g origin/master..HEAD
TEST=util/abuild/abuild -B -e -y -c 50 -p none -x
BRANCH=none
Change-Id: I90795f32be5de881c94519933f36127098c184df
Signed-off-by: Joel Kitching <kitching@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32031
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/foster')
| -rw-r--r-- | src/mainboard/google/foster/chromeos.c | 47 |
1 files changed, 11 insertions, 36 deletions
diff --git a/src/mainboard/google/foster/chromeos.c b/src/mainboard/google/foster/chromeos.c index 4cf2a858c0..024fd4ce7e 100644 --- a/src/mainboard/google/foster/chromeos.c +++ b/src/mainboard/google/foster/chromeos.c @@ -24,46 +24,21 @@ void fill_lb_gpios(struct lb_gpios *gpios) { - int count = 0; - /* TBD(twarren@nvidia.com): Any analogs for these on Foster-FFD? */ + struct lb_gpio chromeos_gpios[] = { + /* Write Protect: active low */ + {-1, ACTIVE_LOW, get_write_protect_state(), "write protect"}, - /* Write Protect: active low */ - gpios->gpios[count].port = -1; - gpios->gpios[count].polarity = ACTIVE_LOW; - gpios->gpios[count].value = get_write_protect_state(); - strncpy((char *)gpios->gpios[count].name, "write protect", - GPIO_MAX_NAME_LENGTH); - count++; - - /* Recovery: active high */ - gpios->gpios[count].port = -1; - gpios->gpios[count].polarity = ACTIVE_HIGH; - gpios->gpios[count].value = get_recovery_mode_switch(); - strncpy((char *)gpios->gpios[count].name, "recovery", - GPIO_MAX_NAME_LENGTH); - count++; - - /* TODO: Power: active low / high depending on board id */ - gpios->gpios[count].port = GPIO(X5); - gpios->gpios[count].polarity = ACTIVE_LOW; - gpios->gpios[count].value = -1; - strncpy((char *)gpios->gpios[count].name, "power", - GPIO_MAX_NAME_LENGTH); - count++; - - /* TODO: Reset: active low (output) */ - gpios->gpios[count].port = GPIO(I5); - gpios->gpios[count].polarity = ACTIVE_LOW; - gpios->gpios[count].value = -1; - strncpy((char *)gpios->gpios[count].name, "reset", - GPIO_MAX_NAME_LENGTH); - count++; + /* Recovery: active high */ + {-1, ACTIVE_HIGH, get_recovery_mode_switch(), "recovery"}, - gpios->size = sizeof(*gpios) + (count * sizeof(struct lb_gpio)); - gpios->count = count; + /* TODO: Power: active low / high depending on board id */ + {GPIO(X5), ACTIVE_LOW, -1, "power"}, - printk(BIOS_ERR, "Added %d GPIOS size %d\n", count, gpios->size); + /* TODO: Reset: active low (output) */ + {GPIO(I5), ACTIVE_LOW, -1, "reset"}, + }; + lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); } int get_recovery_mode_switch(void) |