diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2017-10-03 15:39:22 -0500 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-10-08 22:34:47 +0000 |
| commit | f2fc4972282bfa92be417bc6f3df3197c47ceb01 (patch) | |
| tree | 76aa4d6eb924d19f7f10e14c303fc4b9b1f4eb25 /src/mainboard/google/cyan/Makefile.inc | |
| parent | 43ae4336b232100aa567cb7bd8a66de5f981fe3f (diff) | |
google/cyan: fix variant memory/silicon init params override
The mainboard_memory_init_params() and mainboard_silicon_init_params()
methods already have weak definitions in drivers/intel/fsp1_1,
so having them declared as weak in the cyan baseboard has the effect
of them not being called at all unless overridden at the variant level.
Therefore, remove the weak declarations in the baseboard and ensure
that each variant has its own init functions if needed.
TEST: build/boot google/cyan
Change-Id: I1c76cb5838ef1e65e72c7341d951f9baf2ddd41b
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/21704
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/mainboard/google/cyan/Makefile.inc')
| -rw-r--r-- | src/mainboard/google/cyan/Makefile.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/cyan/Makefile.inc b/src/mainboard/google/cyan/Makefile.inc index 0b11aa3b1d..92b0422279 100644 --- a/src/mainboard/google/cyan/Makefile.inc +++ b/src/mainboard/google/cyan/Makefile.inc @@ -21,10 +21,10 @@ romstage-y += spd/spd.c ramstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-y += ec.c ramstage-y += irqroute.c -ramstage-y += ramstage.c ramstage-y += w25q64.c smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c subdirs-y += variants/$(VARIANT_DIR) +CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include |