summaryrefslogtreecommitdiff
path: root/src/mainboard/google/cherry
diff options
context:
space:
mode:
authorRex-BC Chen <rex-bc.chen@mediatek.com>2022-07-20 11:35:57 +0800
committerFelix Held <felix-coreboot@felixheld.de>2022-07-21 10:33:22 +0000
commitc5d4d964f1728dad5a60d84b8ee0febe0426678b (patch)
treee6418c4f4bcf1e36f4ca34d7828ab218c4666ee1 /src/mainboard/google/cherry
parentd5dafb2c0a6bac5c9d87f0e07e339570e0fd3267 (diff)
mb/google: Use boolean type for "enable" argument for regulator
Because 0 and 1 are the only possible values, 1. Change input argument "enable" of mainboard_enable_regulator to bool. 2. Change return value of mainboard_regulator_is_enabled() to bool. TEST=build pass BUG=b:233720142 Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com> Change-Id: Iae09c5fedf8f7394bfbb677e5aee37ed061304fd Reviewed-on: https://review.coreboot.org/c/coreboot/+/65997 Reviewed-by: Yu-Ping Wu <yupingso@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/cherry')
-rw-r--r--src/mainboard/google/cherry/regulator.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/mainboard/google/cherry/regulator.c b/src/mainboard/google/cherry/regulator.c
index 12de049e98..61f53d1eaf 100644
--- a/src/mainboard/google/cherry/regulator.c
+++ b/src/mainboard/google/cherry/regulator.c
@@ -123,7 +123,7 @@ uint32_t mainboard_get_regulator_voltage(enum mtk_regulator regulator)
return 0;
}
-int mainboard_enable_regulator(enum mtk_regulator regulator, uint8_t enable)
+int mainboard_enable_regulator(enum mtk_regulator regulator, bool enable)
{
if (check_regulator_control(regulator) < 0)
return 0;
@@ -154,17 +154,17 @@ int mainboard_enable_regulator(enum mtk_regulator regulator, uint8_t enable)
return -1;
}
-uint8_t mainboard_regulator_is_enabled(enum mtk_regulator regulator)
+bool mainboard_regulator_is_enabled(enum mtk_regulator regulator)
{
if (check_regulator_control(regulator) < 0)
- return 0;
+ return false;
int id;
id = get_mt6360_regulator_id(regulator);
if (id >= 0) {
if (CONFIG(BOARD_GOOGLE_CHERRY)) {
- return mt6360_is_enabled(id);
+ return !!mt6360_is_enabled(id);
} else {
uint8_t enabled;
if (google_chromeec_regulator_is_enabled(id, &enabled) < 0) {
@@ -172,12 +172,12 @@ uint8_t mainboard_regulator_is_enabled(enum mtk_regulator regulator)
"Failed to retrieve is_enabled by ec; assuming disabled\n");
return 0;
}
- return enabled;
+ return !!enabled;
}
}
printk(BIOS_ERR, "Invalid regulator ID: %d\n; assuming disabled", regulator);
- return 0;
+ return false;
}