summaryrefslogtreecommitdiff
path: root/src/mainboard/google/chell/ec.c
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@chromium.org>2017-10-04 14:01:41 -0700
committerFurquan Shaikh <furquan@google.com>2017-10-08 19:38:28 +0000
commit2749c52080bbaba9e6ce54fb327b7157a7e392c2 (patch)
tree91e05dd62841fe1d1f0f63bba017d1fd11550613 /src/mainboard/google/chell/ec.c
parent687b023d970327e2d4994e5fb170edf9a1e7180f (diff)
ec/google/chromeec: Add library function google_chromeec_events_init
mainboard_ec_init implemented by all x86-based mainboards using chromeec performed similar tasks for initializing and recording ec events. Instead of duplicating this code across multiple boards, provide a library function google_chromeec_events_init that can be called by mainboard with appropriate inputs to perform the required actions. This change also adds a new structure google_chromeec_event_info to allow mainboards to provide information required by the library function to handle different event masks. Also, google_chromeec_log_device_events and google_chromeec_log_events no longer need to be exported. Change-Id: I1cbc24e3e1a31aed35d8527f90ed16ed15ccaa86 Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://review.coreboot.org/21877 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Diffstat (limited to 'src/mainboard/google/chell/ec.c')
-rw-r--r--src/mainboard/google/chell/ec.c28
1 files changed, 8 insertions, 20 deletions
diff --git a/src/mainboard/google/chell/ec.c b/src/mainboard/google/chell/ec.c
index 36cd10acd1..372237800e 100644
--- a/src/mainboard/google/chell/ec.c
+++ b/src/mainboard/google/chell/ec.c
@@ -21,26 +21,14 @@
void mainboard_ec_init(void)
{
- printk(BIOS_DEBUG, "mainboard: EC init\n");
-
- if (acpi_is_wakeup_s3()) {
- google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
- MAINBOARD_EC_S3_WAKE_EVENTS);
-
- /* Disable SMI and wake events */
- google_chromeec_set_smi_mask(0);
+ const struct google_chromeec_event_info info = {
+ .log_events = MAINBOARD_EC_LOG_EVENTS,
+ .sci_events = MAINBOARD_EC_SCI_EVENTS,
+ .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,
+ .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,
+ };
- /* Clear pending events */
- while (google_chromeec_get_event() != 0)
- ;
-
- /* Restore SCI event mask */
- google_chromeec_set_sci_mask(MAINBOARD_EC_SCI_EVENTS);
- } else {
- google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
- MAINBOARD_EC_S5_WAKE_EVENTS);
- }
+ printk(BIOS_DEBUG, "mainboard: EC init\n");
- /* Clear wake event mask */
- google_chromeec_set_wake_mask(0);
+ google_chromeec_events_init(&info, acpi_is_wakeup_s3());
}