summaryrefslogtreecommitdiff
path: root/src/mainboard/google/brya
diff options
context:
space:
mode:
authorReka Norman <rekanorman@google.com>2022-11-21 15:01:02 +1100
committerFelix Held <felix-coreboot@felixheld.de>2022-11-22 12:53:28 +0000
commitf903ef1d5f90728fac9d6772d9c33f9c5ed1501c (patch)
treeaa717d1316cdee600694b5cd1f09298e1d7a87fb /src/mainboard/google/brya
parent1b75e25b0f66e60e029cde93ccd4427c9c8d22c3 (diff)
mb/google/nissa/var/nivviks,yaviks: Remove ISH firmware-name
For nissa, the ISH main firmware will be included in the CSE region in flash instead of loading it from rootfs. So remove the ISH firmware-name. BUG=b:234776154 TEST=Boot to OS on nirwen and yaviks UFS SKUs. Check ISH firmware is not loaded by kernel, and device still goes to S0i3. Cq-Depend: chrome-internal:5102230 Change-Id: I68f963e17bc0dbf9db9adaaa3f96f06b8737523b Signed-off-by: Reka Norman <rekanorman@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69868 Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kangheui Won <khwon@chromium.org>
Diffstat (limited to 'src/mainboard/google/brya')
-rw-r--r--src/mainboard/google/brya/variants/nivviks/overridetree.cb4
-rw-r--r--src/mainboard/google/brya/variants/yaviks/overridetree.cb7
2 files changed, 1 insertions, 10 deletions
diff --git a/src/mainboard/google/brya/variants/nivviks/overridetree.cb b/src/mainboard/google/brya/variants/nivviks/overridetree.cb
index 9567d4fdad..76fe43e71c 100644
--- a/src/mainboard/google/brya/variants/nivviks/overridetree.cb
+++ b/src/mainboard/google/brya/variants/nivviks/overridetree.cb
@@ -519,10 +519,6 @@ chip soc/intel/alderlake
probe STORAGE STORAGE_EMMC
end
device ref ish on
- chip drivers/intel/ish
- register "firmware_name" = ""adl_ish_lite.bin""
- device generic 0 on end
- end
probe STORAGE STORAGE_UFS
end
device ref ufs on
diff --git a/src/mainboard/google/brya/variants/yaviks/overridetree.cb b/src/mainboard/google/brya/variants/yaviks/overridetree.cb
index c3b98b57b5..6b57adae33 100644
--- a/src/mainboard/google/brya/variants/yaviks/overridetree.cb
+++ b/src/mainboard/google/brya/variants/yaviks/overridetree.cb
@@ -212,12 +212,7 @@ chip soc/intel/alderlake
end
end
device ref emmc on end
- device ref ish on
- chip drivers/intel/ish
- register "firmware_name" = ""adl_ish_lite.bin""
- device generic 0 on end
- end
- end
+ device ref ish on end
device ref ufs on end
device ref pch_espi on
chip ec/google/chromeec