summaryrefslogtreecommitdiff
path: root/src/mainboard/google/brya
diff options
context:
space:
mode:
authorSeunghwan Kim <sh_.kim@samsung.corp-partner.google.com>2024-06-03 17:50:47 +0900
committerFelix Held <felix-coreboot@felixheld.de>2024-06-04 14:50:34 +0000
commitb152f10d5a5e2c403929aff708e75e2672c903e9 (patch)
tree4663f14d87d0982023fb28efd7f2f41f870cc247 /src/mainboard/google/brya
parentb870b668344cc298220b85542b697d30bff92e36 (diff)
mb/google/brya/var/xol: Enable FSP UPD LpDdrDqDqsReTraining
Set LpDdrDqDqsReTraining to 1 for xol. Value 0 will cause black screen issue. Reference: https://review.coreboot.org/c/coreboot/+/79527 > FSP default value for LpDdrDqDqsReTraining is 1. For boards > that didn't set LpDdrDqDqsReTraining to any value, 0 was being > assigned and it caused black screen issue. BUG=b:332980211 BRANCH=brya TEST=Built and verified there is no black screen issue during power on/off test for over 100 cycles. Change-Id: Ia346ce559b4509ea1a63abe28b12ad909f9b7b0d Signed-off-by: Seunghwan Kim <sh_.kim@samsung.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82778 Reviewed-by: Eric Lai <ericllai@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Subrata Banik <subratabanik@google.com>
Diffstat (limited to 'src/mainboard/google/brya')
-rw-r--r--src/mainboard/google/brya/variants/xol/memory.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/mainboard/google/brya/variants/xol/memory.c b/src/mainboard/google/brya/variants/xol/memory.c
index 4e294122d2..b0cbaad72f 100644
--- a/src/mainboard/google/brya/variants/xol/memory.c
+++ b/src/mainboard/google/brya/variants/xol/memory.c
@@ -63,6 +63,8 @@ static const struct mb_cfg variant_memcfg = {
.ccc_config = 0xff,
},
+ .LpDdrDqDqsReTraining = 1,
+
.ect = 1, /* Early Command Training */
.UserBd = BOARD_TYPE_ULT_ULX,