diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2019-12-19 19:58:16 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-01-02 14:27:17 +0000 |
| commit | 0558d0c21596c3250e5c31575ac01a4943a3c7d9 (patch) | |
| tree | 6625c298564e299ddc582487f34bc3273a914b6e /src/mainboard/google/beltino | |
| parent | 416f411b8cdb9a3fd8deed14d6af30cf73f9be16 (diff) | |
mb/google/beltino/**/hda_verb.c: Correct pin configs
NIDs 0x18 and 0x19 are flipped, and the verbs for NID 0x1b are instead
applied onto NID 0x1a. Fix that, so that it matches original Chromium
sources for the boards.
Change-Id: I20cc4b282602f8557fa4f25489adf899b7460a09
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37852
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Diffstat (limited to 'src/mainboard/google/beltino')
5 files changed, 15 insertions, 15 deletions
diff --git a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c index a60bee424a..14f1410747 100644 --- a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c +++ b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c @@ -45,16 +45,16 @@ const u32 cim_verb_data[] = { // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x19, 0x03a71011), + AZALIA_PIN_CFG(0, 0x18, 0x03a71011), /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0), /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), /* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c index 9ca85e9f1a..964687c770 100644 --- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c +++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c @@ -41,16 +41,16 @@ const u32 cim_verb_data[] = { AZALIA_PIN_CFG(0, 0x17, 0x411111f0), /* Pin Complex (NID 0x18) MIC1 PORTB - Disabled*/ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), /* Pin Complex (NID 0x19) MIC2 PORTF - 3.5mm Jack*/ - AZALIA_PIN_CFG(0, 0x18, 0x03a11020), + AZALIA_PIN_CFG(0, 0x19, 0x03a11020), /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), /* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable diff --git a/src/mainboard/google/beltino/variants/panther/hda_verb.c b/src/mainboard/google/beltino/variants/panther/hda_verb.c index a60bee424a..14f1410747 100644 --- a/src/mainboard/google/beltino/variants/panther/hda_verb.c +++ b/src/mainboard/google/beltino/variants/panther/hda_verb.c @@ -45,16 +45,16 @@ const u32 cim_verb_data[] = { // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x19, 0x03a71011), + AZALIA_PIN_CFG(0, 0x18, 0x03a71011), /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0), /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), /* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable diff --git a/src/mainboard/google/beltino/variants/tricky/hda_verb.c b/src/mainboard/google/beltino/variants/tricky/hda_verb.c index a60bee424a..14f1410747 100644 --- a/src/mainboard/google/beltino/variants/tricky/hda_verb.c +++ b/src/mainboard/google/beltino/variants/tricky/hda_verb.c @@ -45,16 +45,16 @@ const u32 cim_verb_data[] = { // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x19, 0x03a71011), + AZALIA_PIN_CFG(0, 0x18, 0x03a71011), /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0), /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), /* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable diff --git a/src/mainboard/google/beltino/variants/zako/hda_verb.c b/src/mainboard/google/beltino/variants/zako/hda_verb.c index a60bee424a..14f1410747 100644 --- a/src/mainboard/google/beltino/variants/zako/hda_verb.c +++ b/src/mainboard/google/beltino/variants/zako/hda_verb.c @@ -45,16 +45,16 @@ const u32 cim_verb_data[] = { // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x19, 0x03a71011), + AZALIA_PIN_CFG(0, 0x18, 0x03a71011), /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x411111f0), /* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), /* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */ - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), /* Pin Complex (NID 0x1d) PCBeep */ // eapd low on ex-amp, laptop, custom enable |