diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-06-23 13:55:56 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-08-27 16:03:32 +0000 |
| commit | 19f1e9104a5ae08d031b108a9640bf0f61f61b79 (patch) | |
| tree | acd363b8be339593845f2c2b76a06a86daeea85a /src/mainboard/google/auron/spd.c | |
| parent | 3533808a6dbe335fa76bc82869fb6e9719b250ab (diff) | |
mb/google/auron: Refactor memory-down SPD handling
Variants only need to provide the SPD index and whether said index
corresponds to a dual-channel configuration, which can be achieved
without using `pei_data`. Add two functions that return the values
and use them in `spd.c` at mainboard level.
Change-Id: I9bc4527057d4a771883c8cc60da2501516d6fb94
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55803
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Diffstat (limited to 'src/mainboard/google/auron/spd.c')
| -rw-r--r-- | src/mainboard/google/auron/spd.c | 17 |
1 files changed, 16 insertions, 1 deletions
diff --git a/src/mainboard/google/auron/spd.c b/src/mainboard/google/auron/spd.c index 539026b332..52e4d63915 100644 --- a/src/mainboard/google/auron/spd.c +++ b/src/mainboard/google/auron/spd.c @@ -19,6 +19,8 @@ #define SPD_PART_OFF 128 #define SPD_PART_LEN 18 +#define SPD_LEN 256 + static void mainboard_print_spd_info(uint8_t spd[]) { const int spd_banks[8] = { 8, 16, 32, 64, -1, -1, -1, -1 }; @@ -69,7 +71,7 @@ static void mainboard_print_spd_info(uint8_t spd[]) } } -void fill_spd_for_index(uint8_t spd[], unsigned int spd_index) +static void fill_spd_for_index(uint8_t spd[], unsigned int spd_index) { size_t spd_file_len; uint8_t *spd_file = cbfs_map("spd.bin", &spd_file_len); @@ -95,3 +97,16 @@ void fill_spd_for_index(uint8_t spd[], unsigned int spd_index) mainboard_print_spd_info(spd); } + +/* Copy SPD data for on-board memory */ +void mainboard_fill_spd_data(struct pei_data *pei_data) +{ + const unsigned int spd_index = variant_get_spd_index(); + + fill_spd_for_index(pei_data->spd_data[0][0], spd_index); + + if (variant_is_dual_channel(spd_index)) + memcpy(pei_data->spd_data[1][0], pei_data->spd_data[0][0], SPD_LEN); + else + pei_data->dimm_channel1_disabled = 3; +} |