diff options
| author | Nico Huber <nico.h@gmx.de> | 2018-01-14 12:34:43 +0100 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2018-01-23 05:25:41 +0000 |
| commit | ff4025c5f789b80e6552dd887c34c34642a98c64 (patch) | |
| tree | 852784fb6548c414d41dbdc93f4de6b5b191f9a6 /src/mainboard/gigabyte | |
| parent | 101485c73dbb7eb8d89fbfda1c1bf9a5e495b536 (diff) | |
sb/intel/bd82x6x: Reduce function-disable mess
Most affected boards set the function disabled (FD) register to an
arbitrary state dumped from systems running the vendor BIOS. This
makes it impossible to enable the devices in devicetree and a pretty
big mess of course because nobody cared to keep the register in sync
with the devicetree.
To get completely rid of most of the writes to FD, move setting of
PCH_DISABLE_ALWAYS into the southbridge code where it belongs.
Change-Id: Ia2a507cbcdf218d09738e2e16f0d3ad1dcf57b8b
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/23255
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Hal Martin <hal.martin+coreboot@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Bill XIE <persmule@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/mainboard/gigabyte')
| -rw-r--r-- | src/mainboard/gigabyte/ga-b75m-d3h/romstage.c | 5 | ||||
| -rw-r--r-- | src/mainboard/gigabyte/ga-b75m-d3v/romstage.c | 5 |
2 files changed, 2 insertions, 8 deletions
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c b/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c index cbc55921a8..5a2c935d5a 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c +++ b/src/mainboard/gigabyte/ga-b75m-d3h/romstage.c @@ -61,7 +61,7 @@ static void it8728f_b75md3h_disable_reboot(pnp_devfn_t dev) ite_reg_write(IT8728F_EC, 0x30, 0x01); } -void rcba_config(void) +void mainboard_rcba_config(void) { /* pci_write_config32(PCI_DEV(0, 0x1f, 0), PMBASE, DEFAULT_PMBASE | 1); @@ -131,9 +131,6 @@ void rcba_config(void) RCBA32(0x3844) = 0x0000e5e4; RCBA32(0x3848) = 0x0000000e; */ - /* Disable unused devices (board specific) */ - RCBA32(FD) = 0x17ee1fe1; - /* Enable HECI */ RCBA32(FD2) &= ~0x2; } diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c b/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c index 22a10aef4d..a389e68f0d 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c +++ b/src/mainboard/gigabyte/ga-b75m-d3v/romstage.c @@ -61,11 +61,8 @@ static void it8728f_b75md3v_disable_reboot(pnp_devfn_t dev) ite_reg_write(IT8728F_EC, 0x30, 0x01); } -void rcba_config(void) +void mainboard_rcba_config(void) { - /* Disable unused devices (board specific) */ - RCBA32(FD) = 0x17ee1fe1; - /* Enable HECI */ RCBA32(FD2) &= ~0x2; } |