diff options
author | Jonathan Neuschäfer <j.neuschaefer@gmx.net> | 2016-10-12 00:18:00 +0200 |
---|---|---|
committer | Ronald G. Minnich <rminnich@gmail.com> | 2016-10-15 00:25:05 +0200 |
commit | e2e40cc17e393a5731ec8abdaae622e123f67d5d (patch) | |
tree | 7670a5e1ed8ad9bdd2c87a88425f38a00a7d9fcb /src/mainboard/emulation/spike-riscv | |
parent | 2af174a7dc8fc85f142a895ab3240a83265f7e27 (diff) |
riscv: Clean up {qemu,spike}_util
spike_util.h:
- (LOG_)REGBYTES and STORE are already defined in
arch/riscv/include/bits.h.
- TOHOST_CMD, FROMHOST_* are helper macros for the deprecated
Host-Target Interface (HTIF).
qemu_util.c:
- mcall_query_memory now uses mprv_write_ulong instead of first
translating the address and then accessing it normally. Thus,
translate_address isn't used anymore.
- Several functions used the deprecated HTIF CSRs mtohost/mfromhost.
They have mostly been replaced by stub implementations.
- htif_interrupt and testPrint were unused and have been deleted.
spike_util.c:
- translate_address and testPrint were unused and have been deleted.
After this commit, spike_util.c and qemu_util.c are exactly the same and
can be moved to a common location.
Change-Id: I1789bad8bbab964c3f2f0480de8d97588c68ceaf
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-on: https://review.coreboot.org/16985
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/mainboard/emulation/spike-riscv')
-rw-r--r-- | src/mainboard/emulation/spike-riscv/spike_util.c | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/src/mainboard/emulation/spike-riscv/spike_util.c b/src/mainboard/emulation/spike-riscv/spike_util.c index 7ddf16ba2c..c97a61f246 100644 --- a/src/mainboard/emulation/spike-riscv/spike_util.c +++ b/src/mainboard/emulation/spike-riscv/spike_util.c @@ -33,15 +33,6 @@ #include <string.h> #include <vm.h> -uintptr_t translate_address(uintptr_t vAddr) { - // TODO: implement the page table translation algorithm - //uintptr_t pageTableRoot = read_csr(sptbr); - uintptr_t physAddrMask = 0xfffffff; - uintptr_t translationResult = vAddr & physAddrMask; - printk(BIOS_DEBUG, "Translated virtual address 0x%llx to physical address 0x%llx\n", vAddr, translationResult); - return translationResult; -} - uintptr_t mcall_query_memory(uintptr_t id, memory_block_info *info) { if (id == 0) { @@ -107,13 +98,3 @@ uintptr_t mcall_console_putchar(uint8_t ch) do_putchar(ch); return 0; } - -void testPrint(void) { - /* Print a test command to check Spike console output */ - mcall_console_putchar('h'); - mcall_console_putchar('e'); - mcall_console_putchar('l'); - mcall_console_putchar('l'); - mcall_console_putchar('o'); - mcall_console_putchar('\n'); -} |