diff options
author | Uwe Hermann <uwe@hermann-uwe.de> | 2007-06-19 22:47:11 +0000 |
---|---|---|
committer | Uwe Hermann <uwe@hermann-uwe.de> | 2007-06-19 22:47:11 +0000 |
commit | dfb3c130d5cdd3a01531c23c3d15e7a1010bf221 (patch) | |
tree | 625092b43a0c3ac24fa359eb14df0f922f81e6ad /src/mainboard/asus/mew-vm | |
parent | c72ff11281233c097441e809a52b560b1a131196 (diff) |
Various minor cosmetics and coding style fixes (trivial).
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2727 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/mainboard/asus/mew-vm')
-rw-r--r-- | src/mainboard/asus/mew-vm/auto.c | 44 | ||||
-rw-r--r-- | src/mainboard/asus/mew-vm/irq_tables.c | 2 | ||||
-rw-r--r-- | src/mainboard/asus/mew-vm/mainboard.c | 1 |
3 files changed, 14 insertions, 33 deletions
diff --git a/src/mainboard/asus/mew-vm/auto.c b/src/mainboard/asus/mew-vm/auto.c index 3c993f1fbe..63c5e82704 100644 --- a/src/mainboard/asus/mew-vm/auto.c +++ b/src/mainboard/asus/mew-vm/auto.c @@ -38,10 +38,11 @@ #include "southbridge/intel/i82801xx/i82801xx_early_smbus.c" +/* TODO: Not needed? */ void udelay(int usecs) { int i; - for(i = 0; i < usecs; i++) + for (i = 0; i < usecs; i++) outb(i&0xff, 0x80); } @@ -57,50 +58,31 @@ static void main(unsigned long bist) static const struct mem_controller memctrl[] = { { .d0 = PCI_DEV(0, 0, 0), - .channel0 = { - (0xa << 3) | 0, - (0xa << 3) | 1, - }, + .channel0 = {0x50, 0x51}, } }; - - if (bist == 0) { + + if (bist == 0) early_mtrr_init(); - } - + enable_smbus(); - + lpc47b272_enable_serial(SERIAL_DEV, TTYS0_BASE); uart_init(); console_init(); - /* Halt if there was a built in self test failure */ + /* Halt if there was a built in self test failure. */ report_bist_failure(bist); - //enable_shadow_ram(); + /* dump_spd_registers(&memctrl[0]); */ - //dump_spd_registers(&memctrl[0]); + /* sdram_initialize() runs out of registers. */ + /* sdram_initialize(sizeof(memctrl) / sizeof(memctrl[0]), memctrl); */ - /* sdram_initialize runs out of registers */ - //sdram_initialize(sizeof(memctrl) / sizeof(memctrl[0]), memctrl); - sdram_set_registers(memctrl); sdram_set_spd_registers(memctrl); sdram_enable(0, memctrl); - /* Check whether RAM is working. - * - * Do _not_ check the area from 640 KB - 1 MB, as that's not really - * RAM, but rather reserved for various other things: - * - * - 640 KB - 768 KB: Video Buffer Area - * - 768 KB - 896 KB: Expansion Area - * - 896 KB - 960 KB: Extended System BIOS Area - * - 960 KB - 1 MB: Memory (BIOS Area) - System BIOS Area - * - * Trying to check these areas will fail. - */ - /* TODO: This is currently hardcoded to check 64 MB. */ - //ram_check(0x00000000, 0x0009ffff); /* 0 - 640 KB */ - //ram_check(0x00100000, 0x007c0000); /* 1 MB - 64 MB */ + /* Check RAM. */ + /* ram_check(0, 640 * 1024); */ } diff --git a/src/mainboard/asus/mew-vm/irq_tables.c b/src/mainboard/asus/mew-vm/irq_tables.c index 5794344137..49a3652564 100644 --- a/src/mainboard/asus/mew-vm/irq_tables.c +++ b/src/mainboard/asus/mew-vm/irq_tables.c @@ -38,5 +38,5 @@ that would give 0 after the sum of all bytes for this structure (including check unsigned long write_pirq_routing_table(unsigned long addr) { - return copy_pirq_routing_table(addr); + return copy_pirq_routing_table(addr); } diff --git a/src/mainboard/asus/mew-vm/mainboard.c b/src/mainboard/asus/mew-vm/mainboard.c index 62d18c2cfe..4e03be0fea 100644 --- a/src/mainboard/asus/mew-vm/mainboard.c +++ b/src/mainboard/asus/mew-vm/mainboard.c @@ -4,4 +4,3 @@ struct chip_operations mainboard_asus_mew_vm_ops = { CHIP_NAME("ASUS MEW-VM Mainboard") }; - |