diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-03-08 10:35:49 +0100 |
|---|---|---|
| committer | Felix Singer <felixsinger@posteo.net> | 2021-10-15 09:08:35 +0000 |
| commit | 05ae8f2ff31ba1d02aba15c99025df91588712e1 (patch) | |
| tree | 9828f45dcfca1ed85f6e07c82d68d279dc8f2da1 /src/mainboard/amd | |
| parent | dcc0cc27f4a728e96dd85b88f7321edfcfd7add9 (diff) | |
mainboard: Drop invalid `VGA_BIOS_FILE` defaults
If the VGA BIOS file path for `VGA_BIOS_FILE` in a mainboard's Kconfig
does not exist in the coreboot tree (including submodules), drop it.
These files should be stored in the `site-local` subdirectory and the
paths specified for each board in `site-local/Kconfig`. For example:
config VGA_BIOS_FILE
default "site-local/x200_vbios.bin" if BOARD_LENOVO_X200
Note that this is just an example. There are better ways to structure
one's `site-local` subfolder. Using the `CONFIG_MAINBOARD_DIR` option
would be one of them, though variants may still need special handling.
Also, update autoport to not generate `VGA_BIOS_FILE` defaults.
Change-Id: I1b5dfba035a42d7943f270f95fb7d32b285584d2
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51340
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Diffstat (limited to 'src/mainboard/amd')
| -rw-r--r-- | src/mainboard/amd/inagua/Kconfig | 5 | ||||
| -rw-r--r-- | src/mainboard/amd/persimmon/Kconfig | 5 | ||||
| -rw-r--r-- | src/mainboard/amd/south_station/Kconfig | 4 | ||||
| -rw-r--r-- | src/mainboard/amd/union_station/Kconfig | 4 |
4 files changed, 0 insertions, 18 deletions
diff --git a/src/mainboard/amd/inagua/Kconfig b/src/mainboard/amd/inagua/Kconfig index 8346f52843..3706b3335d 100644 --- a/src/mainboard/amd/inagua/Kconfig +++ b/src/mainboard/amd/inagua/Kconfig @@ -36,11 +36,6 @@ config ONBOARD_VGA_IS_PRIMARY bool default y -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVBios.bin" - config VGA_BIOS_ID string "VGA device PCI IDs" depends on VGA_BIOS diff --git a/src/mainboard/amd/persimmon/Kconfig b/src/mainboard/amd/persimmon/Kconfig index b834570904..66a05ee3c4 100644 --- a/src/mainboard/amd/persimmon/Kconfig +++ b/src/mainboard/amd/persimmon/Kconfig @@ -37,11 +37,6 @@ config ONBOARD_VGA_IS_PRIMARY bool default y -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" diff --git a/src/mainboard/amd/south_station/Kconfig b/src/mainboard/amd/south_station/Kconfig index 883be39644..32eddb48c9 100644 --- a/src/mainboard/amd/south_station/Kconfig +++ b/src/mainboard/amd/south_station/Kconfig @@ -36,10 +36,6 @@ config ONBOARD_VGA_IS_PRIMARY bool default y -config VGA_BIOS_FILE - string - default "site-local/vgabios.bin" - config VGA_BIOS_ID string default "1002,9806" diff --git a/src/mainboard/amd/union_station/Kconfig b/src/mainboard/amd/union_station/Kconfig index ab92013472..0c20e5fecb 100644 --- a/src/mainboard/amd/union_station/Kconfig +++ b/src/mainboard/amd/union_station/Kconfig @@ -35,10 +35,6 @@ config ONBOARD_VGA_IS_PRIMARY bool default y -config VGA_BIOS_FILE - string - default "site-local/vgabios.bin" - config VGA_BIOS_ID string default "1002,9802" |