diff options
author | Nico Huber <nico.h@gmx.de> | 2019-06-06 11:00:36 +0200 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2019-06-06 15:22:43 +0000 |
commit | 21bfc9f99bc88ef4f5bfffde57e1ff142b413028 (patch) | |
tree | 691fd5afbfd082828bdf90cefb3d62bc2d254f8d /src/mainboard/amd | |
parent | 1f12772d19b163f402e14cfa21166c205132f9a8 (diff) |
Revert "libpayload: Reset PS/2 keyboard"
Documentation is scarce on the matter, however the related coreboot
code suggests that after the ACK, the keyboard also sends the result
of the self test (passed/failed). It looks like this result is never
consumed here, probably resulting in further confusion for later com-
mands.
Let's revert this for now (if it's not too late for the 4.10 release)
and break things later again. IMHO, due to the fact that there are
dozens of different keyboard controller and keyboard implementations
and no accurate specification followed, such changes should be tested
on a lot of hardware before merge.
This reverts commit a99ed13e3397bc536012120aab8cadb827913863.
This reverts commit 7ae606f57f0b3d450ae748141b0e2367041b27d3.
Change-Id: I4d4304d5d8a01e013feac61016c59bcaeea81140
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33244
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/mainboard/amd')
0 files changed, 0 insertions, 0 deletions