diff options
| author | Elyes HAOUAS <ehaouas@noos.fr> | 2019-03-18 22:49:36 +0100 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-03-20 20:27:51 +0000 |
| commit | a1e22b8192d5fc85995a41d0961c25293ba4391f (patch) | |
| tree | 7b7dbc885d3ac99fe029cf0961eda1052e753dc1 /src/mainboard/amd | |
| parent | 0eb4db185cfef44ddfdbd91d4fe69a48c127fa84 (diff) | |
src: Use 'include <string.h>' when appropriate
Drop 'include <string.h>' when it is not used and
add it when it is missing.
Also extra lines removed, or added just before local includes.
Change-Id: Iccac4dbaa2dd4144fc347af36ecfc9747da3de20
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31966
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/mainboard/amd')
37 files changed, 0 insertions, 40 deletions
diff --git a/src/mainboard/amd/bettong/acpi_tables.c b/src/mainboard/amd/bettong/acpi_tables.c index b0f297cbb4..8c6840476e 100644 --- a/src/mainboard/amd/bettong/acpi_tables.c +++ b/src/mainboard/amd/bettong/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/bimini_fam10/acpi_tables.c b/src/mainboard/amd/bimini_fam10/acpi_tables.c index d91188754b..e7659d145f 100644 --- a/src/mainboard/amd/bimini_fam10/acpi_tables.c +++ b/src/mainboard/amd/bimini_fam10/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/bimini_fam10/get_bus_conf.c b/src/mainboard/amd/bimini_fam10/get_bus_conf.c index df0a564b76..4021c51ff9 100644 --- a/src/mainboard/amd/bimini_fam10/get_bus_conf.c +++ b/src/mainboard/amd/bimini_fam10/get_bus_conf.c @@ -14,7 +14,6 @@ */ #include <device/pci.h> -#include <string.h> #include <stdint.h> #include <stdlib.h> #include <cpu/amd/multicore.h> diff --git a/src/mainboard/amd/bimini_fam10/mptable.c b/src/mainboard/amd/bimini_fam10/mptable.c index e2aec96945..84c4eda9f8 100644 --- a/src/mainboard/amd/bimini_fam10/mptable.c +++ b/src/mainboard/amd/bimini_fam10/mptable.c @@ -16,7 +16,6 @@ #include <arch/smp/mpspec.h> #include <device/pci.h> #include <arch/io.h> -#include <string.h> #include <stdint.h> #include <southbridge/amd/sb800/sb800.h> #include <cpu/amd/amdfam10_sysconf.h> diff --git a/src/mainboard/amd/bimini_fam10/romstage.c b/src/mainboard/amd/bimini_fam10/romstage.c index 1f77351aab..7b2f0513a4 100644 --- a/src/mainboard/amd/bimini_fam10/romstage.c +++ b/src/mainboard/amd/bimini_fam10/romstage.c @@ -16,7 +16,6 @@ #define SYSTEM_TYPE 1 /* SERVER = 0, DESKTOP = 1, MOBILE = 2 */ #include <stdint.h> -#include <string.h> #include <device/pci_def.h> #include <arch/io.h> #include <device/pci_ops.h> diff --git a/src/mainboard/amd/db-ft3b-lc/acpi_tables.c b/src/mainboard/amd/db-ft3b-lc/acpi_tables.c index 0b9e0c47c9..08f6076e7c 100644 --- a/src/mainboard/amd/db-ft3b-lc/acpi_tables.c +++ b/src/mainboard/amd/db-ft3b-lc/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/db-ft3b-lc/mptable.c b/src/mainboard/amd/db-ft3b-lc/mptable.c index aeb814a81b..3aad0e34f4 100644 --- a/src/mainboard/amd/db-ft3b-lc/mptable.c +++ b/src/mainboard/amd/db-ft3b-lc/mptable.c @@ -17,7 +17,6 @@ #include <arch/smp/mpspec.h> #include <device/pci.h> #include <arch/ioapic.h> -#include <string.h> #include <stdint.h> #include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> diff --git a/src/mainboard/amd/db-ft3b-lc/romstage.c b/src/mainboard/amd/db-ft3b-lc/romstage.c index 2b37f9b2a6..3e9b1c89ca 100644 --- a/src/mainboard/amd/db-ft3b-lc/romstage.c +++ b/src/mainboard/amd/db-ft3b-lc/romstage.c @@ -14,7 +14,6 @@ */ #include <stdint.h> -#include <string.h> #include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> diff --git a/src/mainboard/amd/gardenia/BiosCallOuts.c b/src/mainboard/amd/gardenia/BiosCallOuts.c index 522a63fef1..d4fb55aac0 100644 --- a/src/mainboard/amd/gardenia/BiosCallOuts.c +++ b/src/mainboard/amd/gardenia/BiosCallOuts.c @@ -17,7 +17,6 @@ #include <amdblocks/BiosCallOuts.h> #include <soc/southbridge.h> #include <stdlib.h> -#include <string.h> void platform_FchParams_env(FCH_DATA_BLOCK *FchParams_env) { diff --git a/src/mainboard/amd/inagua/acpi_tables.c b/src/mainboard/amd/inagua/acpi_tables.c index f18a2aa007..787c432041 100644 --- a/src/mainboard/amd/inagua/acpi_tables.c +++ b/src/mainboard/amd/inagua/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/lamar/acpi_tables.c b/src/mainboard/amd/lamar/acpi_tables.c index 1bbd390fed..8b0c2c9690 100644 --- a/src/mainboard/amd/lamar/acpi_tables.c +++ b/src/mainboard/amd/lamar/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/lamar/mptable.c b/src/mainboard/amd/lamar/mptable.c index 5b9170bf71..d89e02fbef 100644 --- a/src/mainboard/amd/lamar/mptable.c +++ b/src/mainboard/amd/lamar/mptable.c @@ -16,7 +16,6 @@ #include <arch/smp/mpspec.h> #include <device/pci.h> #include <arch/ioapic.h> -#include <string.h> #include <stdint.h> #include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> diff --git a/src/mainboard/amd/lamar/romstage.c b/src/mainboard/amd/lamar/romstage.c index bf5c9deeda..3f7d33f11b 100644 --- a/src/mainboard/amd/lamar/romstage.c +++ b/src/mainboard/amd/lamar/romstage.c @@ -14,7 +14,6 @@ */ #include <stdint.h> -#include <string.h> #include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> diff --git a/src/mainboard/amd/mahogany_fam10/acpi_tables.c b/src/mainboard/amd/mahogany_fam10/acpi_tables.c index c907d68a59..6cdf89ac26 100644 --- a/src/mainboard/amd/mahogany_fam10/acpi_tables.c +++ b/src/mainboard/amd/mahogany_fam10/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/mahogany_fam10/get_bus_conf.c b/src/mainboard/amd/mahogany_fam10/get_bus_conf.c index cbf436bf6f..ee2a6caeb9 100644 --- a/src/mainboard/amd/mahogany_fam10/get_bus_conf.c +++ b/src/mainboard/amd/mahogany_fam10/get_bus_conf.c @@ -14,7 +14,6 @@ */ #include <device/pci.h> -#include <string.h> #include <stdint.h> #include <stdlib.h> #include <cpu/amd/multicore.h> diff --git a/src/mainboard/amd/mahogany_fam10/mptable.c b/src/mainboard/amd/mahogany_fam10/mptable.c index bffe1a24f2..090fd54331 100644 --- a/src/mainboard/amd/mahogany_fam10/mptable.c +++ b/src/mainboard/amd/mahogany_fam10/mptable.c @@ -16,11 +16,9 @@ #include <arch/smp/mpspec.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <string.h> #include <stdint.h> #include <cpu/amd/amdfam10_sysconf.h> - extern u32 apicid_sb700; diff --git a/src/mainboard/amd/mahogany_fam10/romstage.c b/src/mainboard/amd/mahogany_fam10/romstage.c index 9140eade9d..c73eb0d388 100644 --- a/src/mainboard/amd/mahogany_fam10/romstage.c +++ b/src/mainboard/amd/mahogany_fam10/romstage.c @@ -18,7 +18,6 @@ //#define SYSTEM_TYPE 2 /* MOBILE */ #include <stdint.h> -#include <string.h> #include <device/pci_def.h> #include <arch/cpu.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/amd/olivehill/acpi_tables.c b/src/mainboard/amd/olivehill/acpi_tables.c index 0b9e0c47c9..08f6076e7c 100644 --- a/src/mainboard/amd/olivehill/acpi_tables.c +++ b/src/mainboard/amd/olivehill/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/olivehill/romstage.c b/src/mainboard/amd/olivehill/romstage.c index 7883a7f792..9a28f98b33 100644 --- a/src/mainboard/amd/olivehill/romstage.c +++ b/src/mainboard/amd/olivehill/romstage.c @@ -14,7 +14,6 @@ */ #include <stdint.h> -#include <string.h> #include <device/pci_def.h> #include <arch/io.h> #include <device/pci_ops.h> diff --git a/src/mainboard/amd/olivehillplus/acpi_tables.c b/src/mainboard/amd/olivehillplus/acpi_tables.c index 0b9e0c47c9..08f6076e7c 100644 --- a/src/mainboard/amd/olivehillplus/acpi_tables.c +++ b/src/mainboard/amd/olivehillplus/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/olivehillplus/romstage.c b/src/mainboard/amd/olivehillplus/romstage.c index 4bb35fb3c0..0181747c22 100644 --- a/src/mainboard/amd/olivehillplus/romstage.c +++ b/src/mainboard/amd/olivehillplus/romstage.c @@ -14,7 +14,6 @@ */ #include <stdint.h> -#include <string.h> #include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> diff --git a/src/mainboard/amd/parmer/acpi_tables.c b/src/mainboard/amd/parmer/acpi_tables.c index 3ff68e3e41..eba2d1da8b 100644 --- a/src/mainboard/amd/parmer/acpi_tables.c +++ b/src/mainboard/amd/parmer/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/persimmon/acpi_tables.c b/src/mainboard/amd/persimmon/acpi_tables.c index f18a2aa007..787c432041 100644 --- a/src/mainboard/amd/persimmon/acpi_tables.c +++ b/src/mainboard/amd/persimmon/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/persimmon/mptable.c b/src/mainboard/amd/persimmon/mptable.c index 8fda6662db..d9f550ea42 100644 --- a/src/mainboard/amd/persimmon/mptable.c +++ b/src/mainboard/amd/persimmon/mptable.c @@ -16,7 +16,6 @@ #include <arch/smp/mpspec.h> #include <device/pci.h> -#include <string.h> #include <stdint.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include <southbridge/amd/common/amd_pci_util.h> diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c b/src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c index 33a81c6327..e1f2409504 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c +++ b/src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <string.h> #include <stdint.h> #include <cpu/amd/multicore.h> diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/mptable.c b/src/mainboard/amd/serengeti_cheetah_fam10/mptable.c index 61aa9067fc..d65b82abf2 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/mptable.c +++ b/src/mainboard/amd/serengeti_cheetah_fam10/mptable.c @@ -16,7 +16,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <device/pci.h> -#include <string.h> #include <stdint.h> #if CONFIG(LOGICAL_CPUS) #include <cpu/amd/multicore.h> diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c b/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c index 427a3ef398..a525154eb3 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c +++ b/src/mainboard/amd/serengeti_cheetah_fam10/romstage.c @@ -16,7 +16,6 @@ #define SYSTEM_TYPE 0 /* SERVER */ #include <stdint.h> -#include <string.h> #include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> diff --git a/src/mainboard/amd/south_station/acpi_tables.c b/src/mainboard/amd/south_station/acpi_tables.c index f18a2aa007..787c432041 100644 --- a/src/mainboard/amd/south_station/acpi_tables.c +++ b/src/mainboard/amd/south_station/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/thatcher/acpi_tables.c b/src/mainboard/amd/thatcher/acpi_tables.c index 3ff68e3e41..eba2d1da8b 100644 --- a/src/mainboard/amd/thatcher/acpi_tables.c +++ b/src/mainboard/amd/thatcher/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/thatcher/romstage.c b/src/mainboard/amd/thatcher/romstage.c index cf8469b519..65ed138c8d 100644 --- a/src/mainboard/amd/thatcher/romstage.c +++ b/src/mainboard/amd/thatcher/romstage.c @@ -14,7 +14,6 @@ */ #include <stdint.h> -#include <string.h> #include <device/pci_def.h> #include <arch/io.h> #include <device/pci_ops.h> diff --git a/src/mainboard/amd/tilapia_fam10/acpi_tables.c b/src/mainboard/amd/tilapia_fam10/acpi_tables.c index 0cdcdb791c..967343da67 100644 --- a/src/mainboard/amd/tilapia_fam10/acpi_tables.c +++ b/src/mainboard/amd/tilapia_fam10/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/tilapia_fam10/get_bus_conf.c b/src/mainboard/amd/tilapia_fam10/get_bus_conf.c index 6bdf94a39d..37a3774e46 100644 --- a/src/mainboard/amd/tilapia_fam10/get_bus_conf.c +++ b/src/mainboard/amd/tilapia_fam10/get_bus_conf.c @@ -14,7 +14,6 @@ */ #include <device/pci.h> -#include <string.h> #include <stdint.h> #include <stdlib.h> #include <cpu/amd/multicore.h> diff --git a/src/mainboard/amd/tilapia_fam10/mptable.c b/src/mainboard/amd/tilapia_fam10/mptable.c index bffe1a24f2..090fd54331 100644 --- a/src/mainboard/amd/tilapia_fam10/mptable.c +++ b/src/mainboard/amd/tilapia_fam10/mptable.c @@ -16,11 +16,9 @@ #include <arch/smp/mpspec.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <string.h> #include <stdint.h> #include <cpu/amd/amdfam10_sysconf.h> - extern u32 apicid_sb700; diff --git a/src/mainboard/amd/tilapia_fam10/romstage.c b/src/mainboard/amd/tilapia_fam10/romstage.c index 0a49d2cd1f..a45d8f6510 100644 --- a/src/mainboard/amd/tilapia_fam10/romstage.c +++ b/src/mainboard/amd/tilapia_fam10/romstage.c @@ -16,7 +16,6 @@ #define SYSTEM_TYPE 1 /* DESKTOP */ #include <stdint.h> -#include <string.h> #include <device/pci_def.h> #include <arch/cpu.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/amd/torpedo/acpi_tables.c b/src/mainboard/amd/torpedo/acpi_tables.c index a68592a130..7d7d86cc95 100644 --- a/src/mainboard/amd/torpedo/acpi_tables.c +++ b/src/mainboard/amd/torpedo/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> diff --git a/src/mainboard/amd/union_station/OemCustomize.c b/src/mainboard/amd/union_station/OemCustomize.c index 8a629011ba..866be54d37 100644 --- a/src/mainboard/amd/union_station/OemCustomize.c +++ b/src/mainboard/amd/union_station/OemCustomize.c @@ -15,8 +15,6 @@ #include <AGESA.h> #include <PlatformMemoryConfiguration.h> - -#include <string.h> #include <northbridge/amd/agesa/state_machine.h> static const PCIe_PORT_DESCRIPTOR PortList[] = { diff --git a/src/mainboard/amd/union_station/acpi_tables.c b/src/mainboard/amd/union_station/acpi_tables.c index f18a2aa007..787c432041 100644 --- a/src/mainboard/amd/union_station/acpi_tables.c +++ b/src/mainboard/amd/union_station/acpi_tables.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ -#include <string.h> #include <arch/acpi.h> #include <arch/ioapic.h> #include <device/pci.h> |