diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-09-07 16:33:26 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-09-19 16:58:38 +0000 |
| commit | 850b6c6254ab34cdbda24818cb0ecca484c01c86 (patch) | |
| tree | 8052c9bf7cc7b18e5ab86acab82383391fd03bd3 /src/mainboard/amd/mandolin/variants | |
| parent | 8c178910221ea59936dd31644bde68a66d586dce (diff) | |
soc/amd/picasso: add eMMC MMIO device to devicetree
Add the eMMC MMIO device to the devicetree and make it use the common
AMD eMMC driver. Since there is now a device for this in the devicetree,
also use this device to determine if the FSP should be told if the eMMC
controller is supposed to be disabled.
TEST=On Mandolin the eMMC controller both disappears in the Windows 10
device manager and in dmesg on Ubuntu 2022.04 LTS
TEST=Morphius with NVMe SSD still works
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I5453b69df776d2ce1f3be11e37cd26c8c64f0cd5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77990
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/mainboard/amd/mandolin/variants')
| -rw-r--r-- | src/mainboard/amd/mandolin/variants/cereme/devicetree.cb | 4 | ||||
| -rw-r--r-- | src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb | 4 |
2 files changed, 0 insertions, 8 deletions
diff --git a/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb b/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb index 167c3667ab..20595e8d77 100644 --- a/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb +++ b/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb @@ -8,10 +8,6 @@ chip soc/amd/picasso register "common_config.fadt_boot_arch" = "ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042" register "common_config.fadt_flags" = "ACPI_FADT_SLEEP_BUTTON" # See table 5-34 ACPI 6.3 spec - register "emmc_config" = "{ - .timing = SD_EMMC_DISABLE, - }" - register "has_usb2_phy_tune_params" = "1" # Controller0 Port0 Default diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb index 1bc5498e3c..9628992857 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb +++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb @@ -8,10 +8,6 @@ chip soc/amd/picasso register "common_config.fadt_boot_arch" = "ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042" register "common_config.fadt_flags" = "ACPI_FADT_SLEEP_BUTTON" # See table 5-34 ACPI 6.3 spec - register "emmc_config" = "{ - .timing = SD_EMMC_DISABLE, - }" - register "has_usb2_phy_tune_params" = "1" # Controller0 Port0 Default |