diff options
author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2013-11-23 19:22:53 -0600 |
---|---|---|
committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-12-02 22:11:20 +0100 |
commit | 72dccce0c9a7cf59ca51a3174fc11eb8899e1761 (patch) | |
tree | 0201395e975f173ebc8badcc952598d559e8a745 /src/lib | |
parent | bcfcfa4473357eb6272bc8bcc5e03f4ba517bcd2 (diff) |
global: Fix usage of get_option() to make use of CB_CMOS_ codes
Do not directly check the return value of get_option, but instead compare
the returned value against a CB_CMOS_ error code, or against CB_SUCCESS.
Change-Id: I2fa7761d13ebb5e9b4606076991a43f18ae370ad
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/4266
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/lib')
-rw-r--r-- | src/lib/uart8250.c | 3 | ||||
-rw-r--r-- | src/lib/uart8250mem.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/lib/uart8250.c b/src/lib/uart8250.c index 261b90f2b2..aa18d2a466 100644 --- a/src/lib/uart8250.c +++ b/src/lib/uart8250.c @@ -123,9 +123,8 @@ void uart_init(void) b_index &= 7; div = divisor[b_index]; #else - if (get_option(&b_index, "baud_rate") == 0) { + if (get_option(&b_index, "baud_rate") == CB_SUCCESS) div = divisor[b_index]; - } #endif #endif diff --git a/src/lib/uart8250mem.c b/src/lib/uart8250mem.c index 8d85855f4c..1482142da0 100644 --- a/src/lib/uart8250mem.c +++ b/src/lib/uart8250mem.c @@ -118,9 +118,8 @@ u32 uart_mem_init(void) b_index &= 7; uart_baud = baud[b_index]; #else - if (get_option(&b_index, "baud_rate") == 0) { + if (get_option(&b_index, "baud_rate") == CB_SUCCESS) uart_baud = baud[b_index]; - } #endif #endif |