diff options
author | Elyes HAOUAS <ehaouas@noos.fr> | 2019-03-01 11:07:06 +0100 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2019-03-04 13:58:11 +0000 |
commit | 80505a6fef22587b5e5a4037d4e83c81236814fd (patch) | |
tree | 1dfac08bc372a8713d2f52a022786e66032edc6d /src/lib/memcmp.c | |
parent | 2796b242b20ca4276f64d09ddabc3ee4c5a81148 (diff) |
sb/intel/i82801gx: Remove unnecessary/redundant ACPI offset operator
Using ACPICA version 20180927 or greater, IASL detects Unnecessary/redundant
uses of the Offset() operator within a Field Unit list.
It then sends a remark "^ Unnecessary/redundant use of Offset".
Offsets refer to the current offset are unnecessary.
example:
OperationRegion (OPR1, SystemMemory, 0x100, 0x100)
Field (OPR1)
{
Offset (0), // Never needed
FLD1, 32,
Offset (4), // Redundant, offset is already 4 (bytes)
FLD2, 8,
Offset (64), // OK use of Offset.
FLD3, 16,
}
We will have those remarks:
dsdt.asl 14: Offset (0),
Remark 2158 - ^ Unnecessary/redundant use of Offset
operator
dsdt.asl 16: Offset (4),
Remark 2158 - ^ Unnecessary/redundant use of Offset
operator
Change-Id: If53072c6a91dd794c70d1fab8697b1713d400fe8
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/31672
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
Diffstat (limited to 'src/lib/memcmp.c')
0 files changed, 0 insertions, 0 deletions