diff options
| author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-08 16:34:12 -0800 |
|---|---|---|
| committer | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-09 17:24:17 +0100 |
| commit | 75b859978a6b1901301f4ee0b53de84d3d83bd0a (patch) | |
| tree | 1598ea4583355b52a86c71c471993e700b2f1ef2 /src/lib/generic_dump_spd.c | |
| parent | eaee1d8a5f6a5a70f7bdf10825e047c0529d5157 (diff) | |
src/lib: Add "int" following "unsigned"
Fix the following warning detected by checkpatch.pl:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
The remaining 37 warnings in gcov-io.c and libgcov.c are all false
positives generated by checkpatch detecting a symbol or function name
ending in _unsigned.
TEST=Build and run on Galileo Gen2
Change-Id: I9f1b71993caca8b3eb3f643525534a937d365ab3
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18695
Tested-by: build bot (Jenkins)
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/lib/generic_dump_spd.c')
| -rw-r--r-- | src/lib/generic_dump_spd.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/lib/generic_dump_spd.c b/src/lib/generic_dump_spd.c index d61ce1ea3c..7f81b3260f 100644 --- a/src/lib/generic_dump_spd.c +++ b/src/lib/generic_dump_spd.c @@ -8,14 +8,14 @@ static void dump_spd_registers(const struct mem_controller *ctrl) int i; printk(BIOS_DEBUG, "\n"); for(i = 0; i < 4; i++) { - unsigned device; + unsigned int device; device = ctrl->channel0[i]; if (device) { int j; printk(BIOS_DEBUG, "dimm: %02x.0: %02x", i, device); for(j = 0; j < 256; j++) { int status; - unsigned char byte; + unsigned int char byte; if ((j & 0xf) == 0) printk(BIOS_DEBUG, "\n%02x: ", j); status = spd_read_byte(device, j); @@ -34,7 +34,7 @@ static void dump_spd_registers(const struct mem_controller *ctrl) printk(BIOS_DEBUG, "dimm: %02x.1: %02x", i, device); for(j = 0; j < 256; j++) { int status; - unsigned char byte; + unsigned int char byte; if ((j & 0xf) == 0) printk(BIOS_DEBUG, "\n%02x: "); status = spd_read_byte(device, j); @@ -53,7 +53,7 @@ static void dump_spd_registers(const struct mem_controller *ctrl) #if 0 void dump_spd_registers(void) { - unsigned device; + unsigned int device; device = SMBUS_MEM_DEVICE_START; printk(BIOS_DEBUG, "\n"); while(device <= SMBUS_MEM_DEVICE_END) { @@ -61,7 +61,7 @@ void dump_spd_registers(void) int i; printk(BIOS_DEBUG, "dimm %02x", device); for(i = 0; (i < 256) && (status == 0); i++) { - unsigned char byte; + unsigned int char byte; if ((i % 20) == 0) { printk(BIOS_DEBUG, "\n%3d: ", i); } |