diff options
| author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-10 17:56:44 -0800 |
|---|---|---|
| committer | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-15 05:05:04 +0100 |
| commit | 36984d85e758bd7b280a835c5c6e5c68b10e82b6 (patch) | |
| tree | 62b7bdc244d5d3c25120fe37fc107de87468a92b /src/lib/edid.c | |
| parent | 491c5b60d01d5fa7d27c281335343e67519e799c (diff) | |
src/lib: Clean up general issues found by checkpatch.pl
Fix the following errors and warnings detected by checkpatch.pl:
ERROR: Bad function definition - void init_timer() should probably be void init_timer(void)
ERROR: Prefixing 0x with decimal output is defective
WARNING: Comparisons should place the constant on the right side of the test
WARNING: char * array declaration might be better as static const
TEST=Build and run on Galileo Gen2
Change-Id: I9f618eea95e1f92fa34f4f89da27c0b16ae7f4ee
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18763
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/lib/edid.c')
| -rw-r--r-- | src/lib/edid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/edid.c b/src/lib/edid.c index 95ff92f22a..58dd813dd2 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -117,7 +117,7 @@ static int detailed_cvt_descriptor(unsigned char *x, int first) { const unsigned char empty[3] = { 0, 0, 0 }; - const char *names[] = { "50", "60", "75", "85" }; + static const char *names[] = { "50", "60", "75", "85" }; int width = 0, height = 0; int valid = 1; int fifty = 0, sixty = 0, seventyfive = 0, eightyfive = 0, reduced = 0; |