summaryrefslogtreecommitdiff
path: root/src/lib/bootmode.c
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-05-02 15:04:00 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-05-18 07:03:22 +0000
commitca00dec624b4763464f98127f2a262b1d0b8f272 (patch)
treeaf34c33df19910357a78efa7738c1ae1c8a0037b /src/lib/bootmode.c
parent8e66124240cb18ecdbca669dee94c5bf04a38364 (diff)
nb/intel/sandybridge: Program IOSAV with macros
This is a temporary solution to simplify refactoring verification. Programming a subsequence involves writing a group of four registers. Abstract this into a "program subsequence" operation. This eliminates register write noise, which should improve the readability of the code. To replace the register writes with assignments to struct fields, we would need to have the values as parameters of a single macro. So, unroll SUBSEQ_CTRL and SP_CMD_ADDR into parameters of IOSAV_SUBSEQUENCE. Line length limits are not for review. Breaking the lines unnecessarily complicates search and replace operations, and wil be taken care of in subsequent commits. Tested with BUILD_TIMELESS=1, ASUS P8Z77-V LX2 remains unchanged. Change-Id: I23f7706ba8a87c1c26f9d40a50b6d47dcf95106a Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40971 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/lib/bootmode.c')
0 files changed, 0 insertions, 0 deletions